diff for duplicates of <4F138CBB.1080901@freescale.com> diff --git a/a/1.txt b/N1/1.txt index 060ea3e..633ebb4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -10,31 +10,34 @@ Michael Neuling wrote: >>> --- >>> Timur: you do compile test your patches, right? :-P >> ->> I have a script that tests each commit in a set to make sure it compiles, +>> I have a script that tests each commit in a set to make sure it compiles= +, >> so that git-bisect isn't broken. > > May I suggest you actually run the script next time :-P -Tomorrow, when I get into the office, I'll take a look. But my code has +Tomorrow, when I get into the office, I'll take a look. But my code has=20 always compiled. Can you give me the output of your compiler? > diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c > index acf292b..3006b2b 100644 > --- a/drivers/video/fsl-diu-fb.c > +++ b/drivers/video/fsl-diu-fb.c -> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state) +> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *= +ofdev, pm_message_t state) > struct fsl_diu_data *data; > -> data = dev_get_drvdata(&ofdev->dev); +> data =3D dev_get_drvdata(&ofdev->dev); > - disable_lcdc(data->fsl_diu_info[0]); > + disable_lcdc(&(data->fsl_diu_info[0])); > > return 0; > } -> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev) +> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *o= +fdev) > struct fsl_diu_data *data; > -> data = dev_get_drvdata(&ofdev->dev); +> data =3D dev_get_drvdata(&ofdev->dev); > - enable_lcdc(data->fsl_diu_info[0]); > + enable_lcdc(&(data->fsl_diu_info[0])); @@ -42,9 +45,10 @@ I prefer this: disable_lcdc(data->fsl_diu_info); -Your change makes sense. I don't understand why it compiles on my system. +Your change makes sense. I don't understand why it compiles on my system.= +=20 Something strange is going on. --- +--=20 Timur Tabi -Linux kernel developer at Freescale +Linux kernel developer at Freescale= diff --git a/a/content_digest b/N1/content_digest index da69a4d..45781c1 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -22,31 +22,34 @@ ">>> ---\n" ">>> Timur: you do compile test your patches, right? :-P\n" ">>\n" - ">> I have a script that tests each commit in a set to make sure it compiles,\n" + ">> I have a script that tests each commit in a set to make sure it compiles=\n" + ",\n" ">> so that git-bisect isn't broken.\n" ">\n" "> May I suggest you actually run the script next time :-P\n" "\n" - "Tomorrow, when I get into the office, I'll take a look. But my code has \n" + "Tomorrow, when I get into the office, I'll take a look. But my code has=20\n" "always compiled. Can you give me the output of your compiler?\n" "\n" "> diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c\n" "> index acf292b..3006b2b 100644\n" "> --- a/drivers/video/fsl-diu-fb.c\n" "> +++ b/drivers/video/fsl-diu-fb.c\n" - "> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *ofdev, pm_message_t state)\n" + "> @@ -1432,7 +1432,7 @@ static int fsl_diu_suspend(struct platform_device *=\n" + "ofdev, pm_message_t state)\n" "> \tstruct fsl_diu_data *data;\n" ">\n" - "> \tdata = dev_get_drvdata(&ofdev->dev);\n" + "> \tdata =3D dev_get_drvdata(&ofdev->dev);\n" "> -\tdisable_lcdc(data->fsl_diu_info[0]);\n" "> +\tdisable_lcdc(&(data->fsl_diu_info[0]));\n" ">\n" "> \treturn 0;\n" "> }\n" - "> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *ofdev)\n" + "> @@ -1442,7 +1442,7 @@ static int fsl_diu_resume(struct platform_device *o=\n" + "fdev)\n" "> \tstruct fsl_diu_data *data;\n" ">\n" - "> \tdata = dev_get_drvdata(&ofdev->dev);\n" + "> \tdata =3D dev_get_drvdata(&ofdev->dev);\n" "> -\tenable_lcdc(data->fsl_diu_info[0]);\n" "> +\tenable_lcdc(&(data->fsl_diu_info[0]));\n" "\n" @@ -54,11 +57,12 @@ "\n" "\tdisable_lcdc(data->fsl_diu_info);\n" "\n" - "Your change makes sense. I don't understand why it compiles on my system. \n" + "Your change makes sense. I don't understand why it compiles on my system.=\n" + "=20\n" " Something strange is going on.\n" "\n" - "-- \n" + "--=20\n" "Timur Tabi\n" - Linux kernel developer at Freescale + Linux kernel developer at Freescale= -e881e9e7c43694436c882cbab39bfe101714dedc312fad1b45f7ae482ba486b7 +a2447a13d42623effa7da4f0eb9dcfd90c243bb1ffec00d6e8ba009e64abac34
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.