From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:52870)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1Rmgq9-0008EP-VB
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 02:18:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1Rmgq8-0001bE-JG
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 02:18:49 -0500
Received: from cantor2.suse.de ([195.135.220.15]:37252 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1Rmgq8-0001b6-Dv
	for qemu-devel@nongnu.org; Mon, 16 Jan 2012 02:18:48 -0500
Message-ID: <4F13CF55.9040008@suse.de>
Date: Mon, 16 Jan 2012 08:18:45 +0100
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
References: <1326453552-17189-1-git-send-email-hare@suse.de>
	<4F1061CE.50005@suse.de> <4F129A9C.9030903@redhat.com>
In-Reply-To: <4F129A9C.9030903@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Alexander Graf <agraf@suse.de>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>, Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>, qemu-devel@nongnu.org

On 01/15/2012 10:21 AM, Avi Kivity wrote:
> On 01/13/2012 06:54 PM, Andreas F=E4rber wrote:
>>> +static void megasas_unmap_sgl(struct megasas_cmd_t *cmd)
>>> +{
>>> +    int i, is_write =3D megasas_frame_is_write(cmd);
>>> +
>>> +    for (i =3D 0; i < cmd->iov_cnt; i++) {
>>> +        cpu_physical_memory_unmap(cmd->iov[i].iov_base, cmd->iov[i].=
iov_len,
>>> +                                  is_write, cmd->iov[i].iov_len);
>>
>> Not sure, but cpu_physical_memory_* sounds old-fashioned. Might need a=
n
>> update to MemoryRegion?
>=20
> These APIs have not been updated (yet?).
>=20
That's what I thought.

Plus even virtio is using it, so I'd be very much interested in the
argument why megasas can't use it ...

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)