From: Li Zefan <lizf@cn.fujitsu.com>
To: Cong Wang <amwang@redhat.com>
Cc: Michal Marek <mmarek@suse.cz>,
Arnaud Lacombe <lacombar@gmail.com>,
Davidlohr Bueso <dave@gnu.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kconfig: fix a regression when exiting menuconfig without saving
Date: Mon, 16 Jan 2012 15:30:30 +0800 [thread overview]
Message-ID: <4F13D216.3060705@cn.fujitsu.com> (raw)
In-Reply-To: <1326698421.4151.4.camel@cr0>
Cong Wang wrote:
> On Mon, 2012-01-16 at 15:01 +0800, Li Zefan wrote:
>> $ make menuconfig
>> HOSTCC scripts/kconfig/mconf.o
>> HOSTLD scripts/kconfig/mconf
>> scripts/kconfig/mconf Kconfig
>>
>> Your configuration changes were NOT saved.
>>
>> make[1]: *** [menuconfig] Error 1
>> make: *** [menuconfig] Error 2
>>
>> Exiting menuconfig without saving, make will report error.
>
> This should be fixed by "[PATCH] scripts:kconfig:mconf.c: let make not
> report error when not save configuration".
>
I didn't notice that patch. I just took a look on it, and unfortunately
that patch is wrong, in that now pressing ESC in the Yes/No dialog will
exit menuconfig instead of returning to the main menu.
next prev parent reply other threads:[~2012-01-16 7:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 7:01 [PATCH] kconfig: fix a regression when exiting menuconfig without saving Li Zefan
2012-01-16 7:20 ` Cong Wang
2012-01-16 7:30 ` Li Zefan [this message]
2012-01-16 7:57 ` [PATCH] menuconfig: fix a regression when canceling the prompt dialog at exit Li Zefan
2012-01-16 8:05 ` Wang YanQing
2012-01-16 13:44 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F13D216.3060705@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=amwang@redhat.com \
--cc=dave@gnu.org \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.