Hi Rodolfo, On 15-Jan-12 4:53 AM, Rodolfo Giometti wrote: > On Sat, Jan 14, 2012 at 04:15:08PM -0600, Alejandro wrote: >> >> The patch looks great, and it is definitely more maintainable. I'll >> create a patch for the w83627ehf driver and send it as soon as >> possible. Should I make the patch for the w83627hf or wait for >> Rodolfo??? > > I already sent a new version of my patches... here you can find a copy > of my message: > > http://www.spinics.net/lists/lm-sensors/msg33656.html > > Please, ask to me whatever you need since I'd like very much these > patches will be added to the kernel main tree! :) > > Ciao, > > Rodolfo The patch as it is posted on "lm-sensors/msg33656.html" mailing list does not apply to the latest tree. After making some changes it applies cleanly to 3.2 tree. The issues were: -The gpio naming convention is now "gpio-[name of the driver]" instead of "[name of driver]_gpio" -Line changes in the Kconfig -Some email addresses converted to @xxxxxxx (by the lm-sensors mailing list I guess) Please look at the attachments for the new patches (I take no credit for the changes as it was a trivial clean-up), if you like the changes I would recommend starting a new thread on this list to get reviews. Note: I couldn't test the driver because my platform has not an HF chip but the patch looks good so far =) BR! Alex