From mboxrd@z Thu Jan 1 00:00:00 1970 From: viresh.kumar@st.com (Viresh Kumar) Date: Mon, 16 Jan 2012 17:14:55 +0530 Subject: [PATCH 7/8] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers In-Reply-To: <20120116105448.GT1068@n2100.arm.linux.org.uk> References: <5e5d0fcff79b9b78e64c7424317d6b77736eca43.1326707233.git.viresh.kumar@st.com> <20120116105448.GT1068@n2100.arm.linux.org.uk> Message-ID: <4F140DB7.3060300@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 1/16/2012 4:24 PM, Russell King - ARM Linux wrote: > Note that DMA engine drivers are not responsible for unmapping the buffers > when the transfer completes - that is the responsibility of the caller. > > The automatic buffer unmapping is required for the async_tx APIs and > offload APIs. In dw_dmac, it is only done for slave transfers. Is this Okay ?? -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753903Ab2APLpS (ORCPT ); Mon, 16 Jan 2012 06:45:18 -0500 Received: from eu1sys200aog116.obsmtp.com ([207.126.144.141]:46316 "EHLO eu1sys200aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752751Ab2APLpR (ORCPT ); Mon, 16 Jan 2012 06:45:17 -0500 Message-ID: <4F140DB7.3060300@st.com> Date: Mon, 16 Jan 2012 17:14:55 +0530 From: Viresh Kumar User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: Russell King - ARM Linux Cc: "vinod.koul@intel.com" , "dan.j.williams@intel.com" , Pratyush ANAND , Rajeev KUMAR , Bhupesh SHARMA , Armando VISCONTI , "linus.walleij@linaro.org" , Mirko GARDI , "linux-kernel@vger.kernel.org" , Vipin KUMAR , Shiraz HASHIM , Amit VIRDI , Vipul Kumar SAMAR , "viresh.linux@gmail.com" , Deepak SIKRI , Bhavna YADAV , "linux-arm-kernel@lists.infradead.org" , Vincenzo FRASCINO Subject: Re: [PATCH 7/8] dmaengine/dw_dmac: Unmap all memory buffers after completion of slave transfers References: <5e5d0fcff79b9b78e64c7424317d6b77736eca43.1326707233.git.viresh.kumar@st.com> <20120116105448.GT1068@n2100.arm.linux.org.uk> In-Reply-To: <20120116105448.GT1068@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/16/2012 4:24 PM, Russell King - ARM Linux wrote: > Note that DMA engine drivers are not responsible for unmapping the buffers > when the transfer completes - that is the responsibility of the caller. > > The automatic buffer unmapping is required for the async_tx APIs and > offload APIs. In dw_dmac, it is only done for slave transfers. Is this Okay ?? -- viresh