From: Anthony Liguori <anthony@codemonkey.ws>
To: "Andreas Färber" <afaerber@suse.de>
Cc: qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>,
Hannes Reinecke <hare@suse.de>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation
Date: Mon, 16 Jan 2012 07:39:21 -0600 [thread overview]
Message-ID: <4F142889.2070109@codemonkey.ws> (raw)
In-Reply-To: <4F1061CE.50005@suse.de>
On 01/13/2012 10:54 AM, Andreas Färber wrote:
> Am 13.01.2012 12:19, schrieb Hannes Reinecke:
>> + if (desc) {
>> + trace_megasas_readl_reg("mmio", desc, retval);
>> + } else {
>> + trace_megasas_readl("mmio", addr, retval);
>> + }
>
> Drop _reg version?
>
> Didn't review the SCSI bits. Patch is pretty large, too. ;)
I have the same thought but it looks to be large because of the header and
tracing file. I didn't see an obvious place to break it up.
Although Hannes, if there is a way to break it up, that would certainly help review.
Regards,
Anthony Liguori
>
> Regards,
> Andreas
>
next prev parent reply other threads:[~2012-01-16 13:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 11:19 [Qemu-devel] [PATCH][v9] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-01-13 16:14 ` Anthony Liguori
2012-01-13 16:35 ` Paolo Bonzini
2012-01-16 9:18 ` Hannes Reinecke
2012-01-16 13:38 ` Anthony Liguori
2012-01-13 16:54 ` Andreas Färber
2012-01-15 9:21 ` Avi Kivity
2012-01-16 7:18 ` Hannes Reinecke
2012-01-16 13:39 ` Anthony Liguori [this message]
2012-01-16 13:59 ` Hannes Reinecke
2012-01-16 14:05 ` Alexander Graf
2012-01-16 14:50 ` Avi Kivity
2012-01-16 15:35 ` Alexander Graf
2012-01-16 15:38 ` Avi Kivity
2012-01-16 15:39 ` Alexander Graf
2012-01-16 15:53 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F142889.2070109@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=avi@redhat.com \
--cc=hare@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.