All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] nand/fsl_elbc: Convert to self-init
Date: Mon, 16 Jan 2012 10:55:32 -0600	[thread overview]
Message-ID: <4F145684.2090002@freescale.com> (raw)
In-Reply-To: <4F145582.1000104@freescale.com>

On 01/16/2012 10:51 AM, Scott Wood wrote:
> On 01/15/2012 01:29 PM, Mike Frysinger wrote:
>> On Thursday 12 January 2012 20:59:41 Scott Wood wrote:
>>> --- a/drivers/mtd/nand/fsl_elbc_nand.c
>>> +++ b/drivers/mtd/nand/fsl_elbc_nand.c
>>>
>>> +#ifndef CONFIG_SYS_NAND_BASE_LIST
>>> +#define CONFIG_SYS_NAND_BASE_LIST { CONFIG_SYS_NAND_BASE }
>>> +#endif
>>
>> would this be better off in nand.h ?
> 
> I'm trying to get away from the model where the NAND subsystem pretends
> to know anything about how a driver talks to its hardware (except when
> the driver chooses to use a common NAND function that uses things like
> IO_ADDR_R/W).  For eLBC it probably makes more sense to specify the
> chipselect rather than the address (we have to search for the former
> based on the latter), though that's a separate change that can happen on
> its own now that the connection to subsystem code has been severed.

Also, even when there isn't a mismatch with the hardware interface, this
frees up the driver to initialize in other ways, separate from a fixed
list iterated over during U-Boot startup -- the addresses could come
from a device tree, for example.

-Scott

  reply	other threads:[~2012-01-16 16:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13  1:59 [U-Boot] [PATCH 1/2] nand: Introduce CONFIG_SYS_NAND_SELF_INIT Scott Wood
2012-01-13  1:59 ` [U-Boot] [PATCH 2/2] nand/fsl_elbc: Convert to self-init Scott Wood
2012-01-15 19:29   ` Mike Frysinger
2012-01-16 16:51     ` Scott Wood
2012-01-16 16:55       ` Scott Wood [this message]
2012-01-16 19:58       ` Mike Frysinger
2012-01-16 20:03         ` Scott Wood
2012-01-16 20:30           ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F145684.2090002@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.