Re: [PATCH] Android port of intel-gpu-tools

[Chad Versace <chad.versace@linux.intel.com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 01/10/2012 08:50 AM, Kavuri, Sateesh wrote:
> 
> 
>> -----Original Message-----
>> From: Adam Jackson [mailto:ajax@redhat.com]
>> Sent: Tuesday, January 10, 2012 8:34 PM
>> To: Kavuri, Sateesh
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] Android port of intel-gpu-tools
>>
>> On 1/9/12 11:45 PM, Sateesh Kavuri wrote:
>>> Added support for Android. Changes include fixes for compilation issues
>>>   related to Android using an older version of GCC compiler (ver 4.3.3)
>>>   while the latest version of intel-gpu-tools confirms to GCC ver 4.5.2
>>>   (C99 standard functions), using functions like getline(). Fixed such
>>>   functions, header dependencies for android and added an Android.mk file.
>>
>> I can understand avoiding C99 functions that android doesn't have, but this kind
>> of thing:
>>
>>> +            #ifdef ANDROID
>>> +	    int i;
>>> +	    for (i = 1; i<  len; i++) {
>>> +            #else
>>>   	    for (int i = 1; i<  len; i++) {
>>> +            #endif
>>
>> is silly.  Does gcc -std=c99 on android seriously not cope with this?
> 
> Yes, -std=c99 would help to get rid of such silly checks (would fix it). Continued 
> this, since there has to be a ANDROID definition for checks like fcntl.h header path
>>
>> - ajax
> 
> --
> Sateesh

I want to see the C99 workarounds removed.

In Mesa we enabled -std=c99 in the Android build with this hack:
    # Use C99.
    ifeq ($(LOCAL_CC),)
    ifeq ($(LOCAL_IS_HOST_MODULE),true)
    LOCAL_CC := $(HOST_CC) -std=c99
    else
    LOCAL_CC := $(TARGET_CC) -std=c99
    endif
    endif

- ----
Chad Versace
chad.versace@linux.intel.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJPFGVPAAoJEAIvNt057x8i+6MP/iX2T5Q9z4zeQB4LlgpNKUVO
5Y6Sl/ZC/AyfWFg1u188pPZvSi6jI86wvZg6MPULzP7NVBx/xG5bsexO0zqDRJ7l
PLridgrxOzUbkreN5jzOI0vV+hVcHfJfuOz9YJ5WTq6LHskPpj/fd3sIbZJRJstg
sGPEFU9Nfp2bVteE35ci4ASYPzdisO/O6sWB5RiDkUJRa+xvBm7NrzBeA4TbxD8f
8lRhKUAcmv1AFtFVJHOUoyL+UkjJXRiI19cSnAB6mr3r6Nf+NCvrN+Kp298ze3xM
/VzLv0GdkmcmtPGzursd8VEEgWwWxWTC39QcURsQjf6+eHs57I77T6XC7YILfGOu
bwMRqCSBygVo6MnCcNlzjCPNHATITgDvRbthSiN8tX2wcrndquNKD1+qBlpoFfVg
d/m8TQD8UAravGkDWwmTxnFFeqXM9pktrTpk55gO+ZNQtkK5SbWtJ9F5O6Yn3trb
8opFiFi6rJdORzSV/4Ma8ySeTaWc7JnANzYaB4PXIJOTTTgUukX9ARWJqYIyRnj9
sBZdG1wrRt89Tlk7KGBQ7f3nXIpMwe9aLYmnajbd6xHMTnzXrEuBZ65r320uUXHo
h+mba6lzJuow3TwcyudvjK5yKPmgQ7ZOV7DmT8wW2pwhVUcIjd4xxgEQsV4xKjLk
SciBCELXKhdkHan8ucml
=fHSl
-----END PGP SIGNATURE-----