From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Matthew Garrett <mjg@redhat.com>, Lin Ming <ming.m.lin@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git patches] libata updates for 3.3
Date: Mon, 16 Jan 2012 15:27:08 -0500 [thread overview]
Message-ID: <4F14881C.8040601@garzik.org> (raw)
In-Reply-To: <CA+55aFxUyBvkAhQZFKDuiJrMx9sR2Nb3s5F3P8wDLa4eNspJ1Q@mail.gmail.com>
On 01/16/2012 03:21 PM, Linus Torvalds wrote:
> On Mon, Jan 16, 2012 at 12:02 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>>
>>> http://www.codon.org.uk/~mjg59/tmp/ahci_quirk_cleanup.diff
>>
>> Hmm. This with just a setup option to enable it might well be good
>> enough. No need for whitelists/blacklists, since we couldn't maintain
>> those sanely anyway.
>
> That patch doesn't work for me. I get a panic in ahci_enable_ahci,
> looks like 'mmio' is bogus there (attempting to dereference 0x01ffe6).
>
> I notice that the PIIX device doesn't have any MMIO at all, it's all
> PIO. Maybe there is some "need to enable MMIO thing" too. Or maybe I
> used the wrong PCI ID when I added it to the quirk table.
Part of the problem with force-enable is that the MMIO BAR may need a
value, and not have it. That, and an expectations mismatch between BIOS
and kernel WRT mode (IDE/AHCI) has always been the reason why
'ahci=force' never made it in. It just never seemed to be reliable broadly.
I'm happy with anything we can get working reliably, even with the
obvious proviso that 'ahci=force' would be a default-off, user-enabled
option. It's always been motherboard/BIOS issues that got in the way.
Jeff
next prev parent reply other threads:[~2012-01-16 20:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 0:32 [git patches] libata updates for 3.3 Jeff Garzik
2012-01-14 5:21 ` Linus Torvalds
2012-01-15 14:41 ` Jeff Garzik
2012-01-16 1:15 ` Lin Ming
2012-01-16 5:23 ` Lin Ming
2012-01-16 19:25 ` Linus Torvalds
2012-01-16 19:29 ` Linus Torvalds
2012-01-16 19:55 ` Linus Torvalds
2012-01-17 5:16 ` Lin Ming
2012-01-17 5:19 ` Linus Torvalds
2012-01-17 16:51 ` Jeff Garzik
2012-01-17 17:00 ` Jeff Garzik
2012-01-16 19:42 ` Alan Cox
2012-01-16 19:47 ` Linus Torvalds
2012-01-16 19:54 ` Alan Cox
2012-01-16 20:02 ` Linus Torvalds
2012-01-16 20:21 ` Linus Torvalds
2012-01-16 20:27 ` Jeff Garzik [this message]
2012-01-16 23:54 ` Alan Cox
2012-01-17 0:02 ` Linus Torvalds
2012-01-17 0:18 ` Matthew Garrett
2012-01-16 21:26 ` Matthew Garrett
2012-01-16 21:34 ` Linus Torvalds
2012-01-16 22:03 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F14881C.8040601@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mjg@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.