All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Weil <sw@weilnetz.de>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/4] console: a few cleanups
Date: Tue, 17 Jan 2012 07:16:34 +0100	[thread overview]
Message-ID: <4F151242.5090001@weilnetz.de> (raw)
In-Reply-To: <1326753397-18476-1-git-send-email-aliguori@us.ibm.com>

Am 16.01.2012 23:36, schrieb Anthony Liguori:
> We don't do anything with the list of registered DisplayState so get rid of it.
> That's one less list to deal with down the road.
>
> Also pass DisplayState to the callbacks in DisplayState so users can avoid
> global state references.
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
> ---
>   console.c          |    9 +++------
>   console.h          |    6 ++----
>   hw/vmware_vga.c    |    4 ++--
>   ui/sdl.c           |    4 ++--
>   ui/spice-display.c |    4 ++--
>   ui/vnc.c           |    4 ++--
>   6 files changed, 13 insertions(+), 18 deletions(-)
>

Is checkpatch.pl buggy, or did you forget to run it?

There are coding style issues at least in patch 1/4 and 2/4.

Regards,

Stefan Weil

  parent reply	other threads:[~2012-01-17  6:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-16 22:36 [Qemu-devel] [PATCH 1/4] console: a few cleanups Anthony Liguori
2012-01-16 22:36 ` [Qemu-devel] [PATCH 2/4] sdl: move globals to a state file, update everything accordingly Anthony Liguori
2012-01-16 22:36 ` [Qemu-devel] [PATCH 3/4] console: pass DisplayAllocator as first argument to methods Anthony Liguori
2012-01-17  6:16 ` Stefan Weil [this message]
2012-01-18  0:49   ` [Qemu-devel] [PATCH 1/4] console: a few cleanups Anthony Liguori
2012-01-18  5:50     ` Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F151242.5090001@weilnetz.de \
    --to=sw@weilnetz.de \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.