From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn2LW-0003W9-Kq for qemu-devel@nongnu.org; Tue, 17 Jan 2012 01:16:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rn2LV-0004qK-9e for qemu-devel@nongnu.org; Tue, 17 Jan 2012 01:16:38 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:43447) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn2LV-0004q9-59 for qemu-devel@nongnu.org; Tue, 17 Jan 2012 01:16:37 -0500 Message-ID: <4F151242.5090001@weilnetz.de> Date: Tue, 17 Jan 2012 07:16:34 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1326753397-18476-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1326753397-18476-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] console: a few cleanups List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org Am 16.01.2012 23:36, schrieb Anthony Liguori: > We don't do anything with the list of registered DisplayState so get rid of it. > That's one less list to deal with down the road. > > Also pass DisplayState to the callbacks in DisplayState so users can avoid > global state references. > > Signed-off-by: Anthony Liguori > --- > console.c | 9 +++------ > console.h | 6 ++---- > hw/vmware_vga.c | 4 ++-- > ui/sdl.c | 4 ++-- > ui/spice-display.c | 4 ++-- > ui/vnc.c | 4 ++-- > 6 files changed, 13 insertions(+), 18 deletions(-) > Is checkpatch.pl buggy, or did you forget to run it? There are coding style issues at least in patch 1/4 and 2/4. Regards, Stefan Weil