From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm, davinci: cam_enc_4xx board updates
Date: Tue, 17 Jan 2012 07:29:21 +0100 [thread overview]
Message-ID: <4F151541.7010309@denx.de> (raw)
In-Reply-To: <CA+M6bX=kCsd1_-aH1KwtkpxSC7biq1qQvTNQPzBNCjc5f5vOsQ@mail.gmail.com>
Hello tom,
Tom Rini wrote:
> On Sun, Jan 15, 2012 at 12:59 AM, Heiko Schocher <hs@denx.de> wrote:
>
> [snip]
>> diff --git a/board/ait/cam_enc_4xx/ublimage.cfg b/board/ait/cam_enc_4xx/ublimage.cfg
>> index 95182ca..2374c72 100644
>> --- a/board/ait/cam_enc_4xx/ublimage.cfg
>> +++ b/board/ait/cam_enc_4xx/ublimage.cfg
>> @@ -39,7 +39,7 @@ PAGES 6
>>
>> # Block number where user bootloader is present
>> # RBL starts always with block 1
>> -START_BLOCK 5
>> +START_BLOCK 0
>
> Is the comment here still correct and fully explaining things? It's a
> little puzzling when I read it, but I don't have a good handle on the
> UBL stuff yet.
The line "# RBL starts always with block 1" is missleading. I delete
this line!
> And aside from expecting a rework of some of this to match Wolfgang's
> comments about FIT images, the rest seems fine to me.
Thanks for your review! I send an update which handles Wolfgangs FIT
comment today.
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
next prev parent reply other threads:[~2012-01-17 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 7:59 [U-Boot] [PATCH] arm, davinci: cam_enc_4xx board updates Heiko Schocher
2012-01-16 17:38 ` Tom Rini
2012-01-17 6:29 ` Heiko Schocher [this message]
2012-01-17 7:20 ` [U-Boot] [PATCH v2] " Heiko Schocher
2012-02-02 18:09 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F151541.7010309@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.