From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn8bP-0006XL-8t for qemu-devel@nongnu.org; Tue, 17 Jan 2012 07:57:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rn8bJ-0003nP-Ic for qemu-devel@nongnu.org; Tue, 17 Jan 2012 07:57:27 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rn8bJ-0003nL-Ab for qemu-devel@nongnu.org; Tue, 17 Jan 2012 07:57:21 -0500 Message-ID: <4F1570FA.6020501@redhat.com> Date: Tue, 17 Jan 2012 14:00:42 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1326460457-19446-1-git-send-email-stefanha@linux.vnet.ibm.com> <1326460457-19446-4-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1326460457-19446-4-git-send-email-stefanha@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 03/15] block: add BlockJob interface for long-running operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Marcelo Tosatti , qemu-devel@nongnu.org, Luiz Capitulino Am 13.01.2012 14:14, schrieb Stefan Hajnoczi: > Signed-off-by: Stefan Hajnoczi > --- > block.c | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ > block_int.h | 40 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 88 insertions(+), 0 deletions(-) > > diff --git a/block.c b/block.c > index daf92c2..d588ee8 100644 > --- a/block.c > +++ b/block.c > @@ -3877,3 +3877,51 @@ out: > > return ret; > } > + > +void *block_job_create(const BlockJobType *job_type, BlockDriverState *bs, > + BlockDriverCompletionFunc *cb, void *opaque) > +{ > + BlockJob *job; > + > + if (bs->job || bdrv_in_use(bs)) { > + return NULL; > + } > + bdrv_set_in_use(bs, 1); > + > + job = g_malloc0(job_type->instance_size); > + job->job_type = job_type; > + job->bs = bs; > + job->cb = cb; > + job->opaque = opaque; > + bs->job = job; > + return job; > +} > + > +void block_job_complete(BlockJob *job, int ret) > +{ > + BlockDriverState *bs = job->bs; > + > + assert(bs->job == job); > + job->cb(job->opaque, ret); > + bs->job = NULL; > + g_free(job); > + bdrv_set_in_use(bs, 0); > +} > + > +int block_job_set_speed(BlockJob *job, int64_t value) > +{ > + if (!job->job_type->set_speed) { > + return -ENOTSUP; > + } > + return job->job_type->set_speed(job, value); > +} > + > +void block_job_cancel(BlockJob *job) > +{ > + job->cancelled = true; > +} > + > +bool block_job_is_cancelled(BlockJob *job) > +{ > + return job->cancelled; > +} > diff --git a/block_int.h b/block_int.h > index 5362180..316443e 100644 > --- a/block_int.h > +++ b/block_int.h > @@ -69,6 +69,36 @@ typedef struct BlockIOBaseValue { > uint64_t ios[2]; > } BlockIOBaseValue; > > +typedef void BlockJobCancelFunc(void *opaque); > +typedef struct BlockJob BlockJob; > +typedef struct BlockJobType { > + /** Derived BlockJob struct size */ > + size_t instance_size; > + > + /** String describing the operation, part of query-block-jobs QMP API */ > + const char *job_type; > + > + /** Optional callback for job types that support setting a speed limit */ > + int (*set_speed)(BlockJob *job, int64_t value); Would be worth mentioning what the unit of value is. Kevin