From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from am1ehsobe001.messaging.microsoft.com ([213.199.154.204] helo=AM1EHSOBE001.bigfish.com) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1RnEQ3-0002ib-13 for linux-mtd@lists.infradead.org; Tue, 17 Jan 2012 19:10:08 +0000 Message-ID: <4F15C788.2050701@freescale.com> Date: Tue, 17 Jan 2012 13:10:00 -0600 From: Scott Wood MIME-Version: 1.0 To: Kumar Gala Subject: Re: [PATCH 2/2][v2] mtd/nand: Fix IFC driver to support 2K NAND page References: <1326111866-13120-1-git-send-email-prabhakar@freescale.com> <4F0B901C.6020100@freescale.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Cc: Poonam Aggrwal , linuxppc-dev@lists.ozlabs.org, linux-mtd@lists.infradead.org, Prabhakar Kushwaha List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 01/17/2012 12:57 PM, Kumar Gala wrote: > > On Jan 9, 2012, at 7:10 PM, Scott Wood wrote: > >> On 01/09/2012 06:24 AM, Prabhakar Kushwaha wrote: >>> 1) OOB area should be updated irrespective of NAND page size. Earlier it was >>> updated only for 512byte NAND page. >>> >>> 2) During OOB update fbcr should be equal to OOB size. >>> >>> Signed-off-by: Poonam Aggrwal >>> Signed-off-by: Prabhakar Kushwaha >>> --- >>> git://git.kernel.org/pub/scm/linux/kernel/git/galak/powerpc.git (branch next) >>> >>> This patch is created on top of IFC driver patch (already floated in mailing >>> list). Please find their link: >>> http://patchwork.ozlabs.org/patch/133315/ >>> http://patchwork.ozlabs.org/patch/133316/ >> >> Looks good. >> >> -Scott > > Can we not merge all these into one updated IFC NAND patch? Sure, once we've agreed on what the right fix is for the is_blank issue (and I think we're pretty close). It's been useful to see these fixes as separate patches during the review/iteration phase, though. -Scott