From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47679)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RnTAw-000251-JF
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 05:55:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RnTAs-00041r-FG
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 05:55:30 -0500
Received: from cantor2.suse.de ([195.135.220.15]:51415 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1RnTAr-00041i-VJ
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 05:55:26 -0500
Message-ID: <4F16A4AA.20400@suse.de>
Date: Wed, 18 Jan 2012 11:53:30 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1326882794-31816-1-git-send-email-pbonzini@redhat.com>
	<1326882794-31816-6-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1326882794-31816-6-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH 5/9] qtest: do not use TCG CPU threads
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

Am 18.01.2012 11:33, schrieb Paolo Bonzini:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  cpu-exec.c |    4 ---
>  cpus.c     |   62 ++++++++++++++++++++++++++++++++++++++++++++++++++++=
+++++--
>  2 files changed, 59 insertions(+), 7 deletions(-)

> diff --git a/cpus.c b/cpus.c
> index 2dae549..c4ca26a 100644
> --- a/cpus.c
> +++ b/cpus.c

> -    if (kvm_enabled() && !env->thread_kicked) {
> +    if (!tcg_enabled() && !env->thread_kicked) {

> -    if (kvm_enabled()) {
> +    if (!tcg_enabled()) {

>      if (kvm_enabled()) {
>          qemu_kvm_start_vcpu(env);
> -    } else {
> +    } else if (tcg_enabled()) {
>          qemu_tcg_init_vcpu(env);
> +    } else {
> +        qemu_dummy_start_vcpu(env);
>      }

Did you keep Xen in mind when changing the logic?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg