From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48454)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RnTTn-00088h-2L
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 06:15:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RnTTj-000062-3o
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 06:14:58 -0500
Received: from mx1.redhat.com ([209.132.183.28]:30663)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1RnTTi-00005w-TM
	for qemu-devel@nongnu.org; Wed, 18 Jan 2012 06:14:55 -0500
Message-ID: <4F16A9A9.9020506@redhat.com>
Date: Wed, 18 Jan 2012 12:14:49 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1326882794-31816-1-git-send-email-pbonzini@redhat.com>
	<1326882794-31816-6-git-send-email-pbonzini@redhat.com>
	<4F16A4AA.20400@suse.de>
In-Reply-To: <4F16A4AA.20400@suse.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH 5/9] qtest: do not use TCG CPU threads
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 01/18/2012 11:53 AM, Andreas F=E4rber wrote:
> > -    if (kvm_enabled()&&  !env->thread_kicked) {
> >  +    if (!tcg_enabled()&&  !env->thread_kicked) {
> >  -    if (kvm_enabled()) {
> >  +    if (!tcg_enabled()) {
> >        if (kvm_enabled()) {
> >            qemu_kvm_start_vcpu(env);
> >  -    } else {
> >  +    } else if (tcg_enabled()) {
> >            qemu_tcg_init_vcpu(env);
> >  +    } else {
> >  +        qemu_dummy_start_vcpu(env);
> >        }
> Did you keep Xen in mind when changing the logic?

Yes, though I didn't test it.  There's no reason why Xen should depend=20
on any TCG code.

Paolo