From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefano Babic <sbabic@denx.de>
Date: Wed, 18 Jan 2012 13:37:31 +0100
Subject: [U-Boot] [PATCH V3 2/2] tt01: add MMC support
In-Reply-To: <1326883264-21618-2-git-send-email-helmut.raiger@hale.at>
References: <4F15497A.1060503@denx.de>
	<1326883264-21618-1-git-send-email-helmut.raiger@hale.at>
	<1326883264-21618-2-git-send-email-helmut.raiger@hale.at>
Message-ID: <4F16BD0B.9040200@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 18/01/2012 11:41, Helmut Raiger wrote:
> board_mmc_init() initializes the pins of SDHC1 and
> turns on V_MMC1 of the PMIC. Config adds support for EXT2
> and FAT.
> 
> Signed-off-by: Helmut Raiger <helmut.raiger@hale.at>
> ---

Hi Helmut,

> +#ifdef CONFIG_CONSOLE_EXTRA_INFO
> +void video_get_info_str(int line_number, char *info)

This has nothing with MCC. Please extend your commit message to explain
you are also adding this feature.

> +{
> +	u32 srev = get_cpu_rev();
> +
> +	switch (line_number) {
> +	case 2:
> +		sprintf(info, " CPU  : Freescale i.MX31 rev %d.%d%s at %d MHz",
> +				(srev & 0xF0) >> 4, (srev & 0x0F),
> +				((srev & 0x8000) ? " unknown" : ""),
> +				mxc_get_clock(MXC_ARM_CLK) / 1000000);

I know it is only one line, but it is not related to your board because
it is really print_cpuinfo() into a buffer. So this cpu part should be
moved into the SOC place (arch/arm/cpu/arm1136/mx31/generic.c).

However, which is the real reason to do that ? I have supposed that
setting video as stdout it is enough to redirect all output to the LCD,
and then the usual print_cpuinfo() works, without adding / duplicating
function that already use printf() for the output.

I do not see a lot of boards implementing video_get_info_str(), and I
understand that it is a way to customize the output. However, is it the
correct way ? Does print_cpuinfo() not work if redirect to the video ? I
have added Anatolji (video maintainer in CC) to get his opinion.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================