From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits
Date: Wed, 18 Jan 2012 17:43:28 +0100 [thread overview]
Message-ID: <4F16F6B0.7030707@ti.com> (raw)
In-Reply-To: <20120118152905.GP8732@opensource.wolfsonmicro.com>
On 01/18/2012 04:29 PM, Mark Brown wrote:
> I'm not sure this is actually a legibility improvement, if anything it's
> probably less clear than the original as now the setup of the loop is
> spread even further around the function.
Would it make it clearer if I set i to 0 right before the while?
>> Most of the drivers require 24/32 configuration, so not point of looping
>> for smaller sample sizes.
>
> Performance isn't really a concern in this path unless we do something
> totally insane. Thinking time on the part of the reader needs to be
> considered too...
Sure it is not a concern. These small 'Performance isn't really a
concern in this path' at the end ads up that we need faster CPUs to have
the same perceived perfomrance.
--
Péter
next prev parent reply other threads:[~2012-01-18 16:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 15:05 [PATCH v5] ASoC: Apply msbits constraint for sample size bigger than the msbits Peter Ujfalusi
2012-01-18 15:29 ` Mark Brown
2012-01-18 16:43 ` Peter Ujfalusi [this message]
2012-01-18 17:46 ` Mark Brown
2012-01-19 8:27 ` Peter Ujfalusi
2012-01-19 10:48 ` Mark Brown
2012-01-19 12:40 ` Peter Ujfalusi
2012-01-19 15:39 ` Mark Brown
2012-01-18 15:35 ` Clemens Ladisch
2012-01-18 15:43 ` Peter Ujfalusi
2012-01-18 15:49 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F16F6B0.7030707@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.