Re: [PATCHv3 0/4] Unify SPN reading logic

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1078 bytes --]

Hi Oleg,

On 01/18/2012 05:56 AM, Oleg Zhurakivskyy wrote:
> Hello,
> 
> Please find the changes in order not to duplicate the SPN reading logic in src/grps.c and src/network.c.
> 
> Changes from v2:
> 
> - Removed sim_watch() capability from gprs.c
> - Corrected the operator name emission logic.
> - In order to save some memory, netreg accesses the spn directly
>   from the sim atom.
> 
> Regards,
> Oleg
> 
> Oleg Zhurakivskyy (4):
>   gprs: Use sim SPN watch API
>   network: Use sim SPN watch API
>   sim: Add ofono_sim_get_spn()
>   network: Access SPN directly from the sim atom
> 
>  include/sim.h |    1 +
>  src/gprs.c    |   71 ++++++++++-------------
>  src/network.c |  171 ++++++---------------------------------------------------
>  src/sim.c     |    8 +++
>  4 files changed, 58 insertions(+), 193 deletions(-)
> 

All four patches have been applied, thanks.  I did break up patch 3 into
two patches and performed some minor refactoring afterwards.  Please
review and make sure I didn't screw anything up.

Regards,
-Denis