From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Date: Wed, 18 Jan 2012 17:30:19 -0700 Subject: [U-Boot] [PATCH v4 17/20] tegra: usb: Add USB support to nvidia boards In-Reply-To: <1326342789-5781-18-git-send-email-sjg@chromium.org> References: <1326342789-5781-1-git-send-email-sjg@chromium.org> <1326342789-5781-18-git-send-email-sjg@chromium.org> Message-ID: <4F17641B.9030301@nvidia.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 01/11/2012 09:33 PM, Simon Glass wrote: > This adds basic USB support for port 0. The other port is not supported > yet. > diff --git a/board/nvidia/common/board.c b/board/nvidia/common/board.c > +#ifdef CONFIG_USB_EHCI_TEGRA > + /* For USB GPIO PD0. for now, since we have no pinmux in fdt */ > + pinmux_tristate_disable(PINGRP_SLXK); Can we ifdef this so it only happens on Seaboard? Who knows what other boards use that pin group for. Unfortunately, I checked and this really does appear required for Seaboard, since there's no pull on the USB1_VBUS_EN GPIO, so Tegra must drive it. -- nvpublic