diff for duplicates of <4F177907.4000806@samsung.com> diff --git a/a/1.txt b/N1/1.txt index 50f9a4f..b939a3c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -113,7 +113,7 @@ Yes, >> + if (!lcd_dev) >> + continue; >> + ->> + if ((strcmp(lcd_drv->name, lcd_dev->name)) = 0) { +>> + if ((strcmp(lcd_drv->name, lcd_dev->name)) == 0) { > > hm, using strcmp() to compare devices in this way looks fishy. But I > don't know what is going on here. @@ -204,7 +204,7 @@ Ok, I will fix it. >> + dev_dbg(dsim->dev, "lcd_dev->bus_id = %d, dsim->id = %d\n", >> + lcd_dev->bus_id, dsim->id); >> + ->> + if ((strcmp(lcd_drv->name, name) = 0)) { +>> + if ((strcmp(lcd_drv->name, name) == 0)) { >> + lcd_dev->master = dsim; >> + >> + lcd_dev->dev.parent = dsim->dev; @@ -260,7 +260,7 @@ Ok, I will fix it. >> + >> + /* get mipi_dsim_platform_data. */ >> + dsim_pd = (struct mipi_dsim_platform_data *)dsim->pd; ->> + if (dsim_pd = NULL) { +>> + if (dsim_pd == NULL) { >> + dev_err(&pdev->dev, "failed to get platform data for dsim.\n"); >> + goto err_clock_get; >> + } diff --git a/a/content_digest b/N1/content_digest index 1f015c9..48e0ebc 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\04F16288C.5020406@samsung.com\0" "ref\020120118130550.0bdb227e.akpm@linux-foundation.org\0" - "From\0Donghwa Lee <dh09.lee@samsung.com>\0" - "Subject\0Re: [PATCH v6 1/2] video: support MIPI-DSI controller driver\0" - "Date\0Thu, 19 Jan 2012 01:59:35 +0000\0" + "From\0dh09.lee@samsung.com (Donghwa Lee)\0" + "Subject\0[PATCH v6 1/2] video: support MIPI-DSI controller driver\0" + "Date\0Thu, 19 Jan 2012 10:59:35 +0900\0" "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" @@ -121,7 +121,7 @@ ">> +\t\tif (!lcd_dev)\n" ">> +\t\t\tcontinue;\n" ">> +\n" - ">> +\t\tif ((strcmp(lcd_drv->name, lcd_dev->name)) = 0) {\n" + ">> +\t\tif ((strcmp(lcd_drv->name, lcd_dev->name)) == 0) {\n" "> \n" "> hm, using strcmp() to compare devices in this way looks fishy. But I\n" "> don't know what is going on here.\n" @@ -212,7 +212,7 @@ ">> +\t\tdev_dbg(dsim->dev, \"lcd_dev->bus_id = %d, dsim->id = %d\\n\",\n" ">> +\t\t\t\tlcd_dev->bus_id, dsim->id);\n" ">> +\n" - ">> +\t\tif ((strcmp(lcd_drv->name, name) = 0)) {\n" + ">> +\t\tif ((strcmp(lcd_drv->name, name) == 0)) {\n" ">> +\t\t\tlcd_dev->master = dsim;\n" ">> +\n" ">> +\t\t\tlcd_dev->dev.parent = dsim->dev;\n" @@ -268,7 +268,7 @@ ">> +\n" ">> +\t/* get mipi_dsim_platform_data. */\n" ">> +\tdsim_pd = (struct mipi_dsim_platform_data *)dsim->pd;\n" - ">> +\tif (dsim_pd = NULL) {\n" + ">> +\tif (dsim_pd == NULL) {\n" ">> +\t\tdev_err(&pdev->dev, \"failed to get platform data for dsim.\\n\");\n" ">> +\t\tgoto err_clock_get;\n" ">> +\t}\n" @@ -326,4 +326,4 @@ "> \n" > -650605165ab347550758199a69f4d12da219fec62b8d75f5425d2fc9bf24be12 +0a539848d59b0cdfb49f4274e42600bb8528c9fab9dc645f93eebcf7f6025bcf
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.