From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:43528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnmHP-000654-3s for qemu-devel@nongnu.org; Thu, 19 Jan 2012 02:19:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RnmHJ-0002NN-7y for qemu-devel@nongnu.org; Thu, 19 Jan 2012 02:19:26 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:63344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RnmHJ-0002MH-3h for qemu-devel@nongnu.org; Thu, 19 Jan 2012 02:19:21 -0500 Received: from euspt1 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0LY100EXPAZZMK@mailout2.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 19 Jan 2012 07:19:11 +0000 (GMT) Received: from [106.109.8.195] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0LY100KF5AZY5K@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Thu, 19 Jan 2012 07:19:11 +0000 (GMT) Date: Thu, 19 Jan 2012 11:19:09 +0400 From: Evgeny Voevodin In-reply-to: Message-id: <4F17C3ED.5030604@samsung.com> MIME-version: 1.0 Content-type: text/plain; format=flowed; charset=UTF-8 Content-transfer-encoding: QUOTED-PRINTABLE References: <1326696515-6747-1-git-send-email-e.voevodin@samsung.com> <1326696515-6747-8-git-send-email-e.voevodin@samsung.com> Subject: Re: [Qemu-devel] [PATCH v7 07/10] ARM: exynos4210: MCT support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: kyungmin.park@samsung.com, m.kozlov@samsung.com, jehyung.lee@samsung.com, qemu-devel@nongnu.org, d.solodkiy@samsung.com On 01/18/2012 03:46 PM, Peter Maydell wrote: > On 16 January 2012 06:48, Evgeny Voevodin = wrote: > This doesn't compile on 32 bit hosts: > > CC arm-softmmu/exynos4210_mct.o > cc1: warnings being treated as errors > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In > function =E2=80=98exynos4210_gcomp_get_distance=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:485= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:487= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:490= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In > function =E2=80=98exynos4210_gfrc_restart=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:507= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:508= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In > function =E2=80=98exynos4210_gfrc_event=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:575= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:576= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In > function =E2=80=98exynos4210_lfrc_update_count=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:599= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c: In > function =E2=80=98exynos4210_ltick_recalc_count=E2=80=99: > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:843= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > /home/petmay01/linaro/qemu-from-laptop/qemu/hw/exynos4210_mct.c:845= : > error: integer constant is too large for =E2=80=98long=E2=80=99 typ= e > make[1]: *** [exynos4210_mct.o] Error 1 > > These two 64 bit constants need a ULL suffix: > >> +#define MCT_GT_COUNTER_STEP 0x100000000 >> +#define MCT_LT_COUNTER_STEP 0x100000000 > -- PMM > Thanks. gcc 4.5 compiles it quietly on our systems, but 4.4 reports= =20 warnings. Will fix and provide v8 soon. --=20 Kind regards, Evgeny Voevodin, Leading Software Engineer, ASWG, Moscow R&D center, Samsung Electronics e-mail: e.voevodin@samsung.com