From: Tudor Laurentiu <Laurentiu.Tudor@freescale.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/booke64: Configurable lazy interrupt disabling
Date: Thu, 19 Jan 2012 15:18:13 +0200 [thread overview]
Message-ID: <4F181815.7000704@freescale.com> (raw)
In-Reply-To: <1326921026.26116.34.camel@pasglop>
Hi Ben,
On 01/18/2012 11:10 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2012-01-18 at 16:35 +0200, Laurentiu Tudor wrote:
>> This patch adds a menuconfig option that allows controlling
>> the lazy interrupt disabling feature implemented by this
>> commit:
>>
>> commit d04c56f73c30a5e593202ecfcf25ed43d42363a2
>> Author: Paul Mackerras
>> Date: Wed Oct 4 16:47:49 2006 +1000
>>
>> [POWERPC] Lazy interrupt disabling for 64-bit machines
>>
>> The code in 'powerpc/include/asm/hw_irq.h' was rearranged and
>> cleaned-up a bit in order to reduce the number of needed #ifdef's.
>
> It's still nasty.
Yep, there is still room for improvement. Perhaps trimming some of those
various interrupt enable/disable functions & macros. However I don't
think I have enough experience to do this ... so, any suggestions are
welcomed.
> Do you have numbers showing that it's worth disabling
> on BookE ?
On fsl's p5020 there should be some performance gains because disabling
"lazy ee" allows enabling the "external proxy" feature.
The thing is I can't prove this because I have no idea what benchmark to
run. Let me know if you guys know of any relevant benchmark I could try.
---
Best Regards, Laurentiu
next prev parent reply other threads:[~2012-01-19 13:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 14:35 [PATCH] powerpc/booke64: Configurable lazy interrupt disabling Laurentiu Tudor
2012-01-18 21:10 ` Benjamin Herrenschmidt
2012-01-19 13:18 ` Tudor Laurentiu [this message]
2012-01-19 19:21 ` Stuart Yoder
2012-01-19 19:29 ` Stuart Yoder
2012-01-20 23:05 ` Benjamin Herrenschmidt
2012-01-23 19:21 ` Scott Wood
2012-01-23 20:50 ` Benjamin Herrenschmidt
2012-01-25 14:32 ` Tudor Laurentiu
2012-01-30 21:47 ` Scott Wood
2012-01-30 22:15 ` Benjamin Herrenschmidt
2012-01-30 23:13 ` Scott Wood
2012-01-20 23:02 ` Benjamin Herrenschmidt
2012-01-23 19:31 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F181815.7000704@freescale.com \
--to=laurentiu.tudor@freescale.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.