All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Smart <james.smart@emulex.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 01/07] lpfc 8.3.29: BSG and User interface fixes
Date: Thu, 19 Jan 2012 12:33:37 -0500	[thread overview]
Message-ID: <4F1853F1.4020909@emulex.com> (raw)
In-Reply-To: <4F174603.8060104@cs.wisc.edu>

Yes.

I'm open to either the scsi_lib helper function, so we have consistent 
naming.  However, the real answer is to fix bsg to take out references on the 
object that registers with bsg - so that driver unload is gated on proper 
unregistration, and no outstanding bsg requests.  Who knows bsg well enough to 
do this ?

-- james s


On 1/18/2012 5:21 PM, Mike Christie wrote:
> On 01/18/2012 03:23 PM, James Smart wrote:
>> >  - Create character device to take a reference on the driver (126082)
>> >
> Is this so the driver cannot get unloaded when doing multiple bsg/sysfs
> requests? If so having every driver create its own char device seems
> wrong. qla2xxx does this too.qla4xxx wants to do it.  Every driver has
> the problem.
>
> If we do this can we at least have a scsi lib helper function that can
> enforce a consistent naming policy for the char devs so userspace apps
> do not have to have some crazy look up table for every driver.
>
> Or, is there a better way to support this? Maybe a common sysfs attr on
> the host or a bsg request? Something common that works for all drivers
> so we do not have to go around to every driver and add char device to them?
>
>
>

  reply	other threads:[~2012-01-19 17:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 21:23 [PATCH 01/07] lpfc 8.3.29: BSG and User interface fixes James Smart
2012-01-18 22:21 ` Mike Christie
2012-01-19 17:33   ` James Smart [this message]
2012-01-25 22:34     ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1853F1.4020909@emulex.com \
    --to=james.smart@emulex.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=michaelc@cs.wisc.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.