From: "H. Peter Anvin" <hpa@zytor.com>
To: Michael D Labriola <mlabriol@gdeb.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Kushal Koolwal <kushalkoolwal@gmail.com>,
linux-kernel@vger.kernel.org, michael.d.labriola@gmail.com,
Ingo Molnar <mingo@elte.hu>,
Matthew Garrett <mjg59@srcf.ucam.org>,
support@versalogic.com, Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org
Subject: Re: [PATCH] x86, reboot: skip DMI checks if reboot set by user
Date: Thu, 19 Jan 2012 09:52:15 -0800 [thread overview]
Message-ID: <4F18584F.7060603@zytor.com> (raw)
In-Reply-To: <OF2B909250.6078896E-ON8525798A.0058FF49-8525798A.0061AEA1@gdeb.com>
On 01/19/2012 09:46 AM, Michael D Labriola wrote:
>
> Random question... why do we have a reboot_init function that does DMI
> checking with reboot_dmi_table (callbacks are mostly set_bios_reboot, but
> there is a single set_kbd_reboot) and also a pci_reboot_init which does
> the DMI check again using a separate pci_reboot_dmi_table (all callbacks
> are to set_pci_reboot)?
>
> Wouldn't it make more sense to do a single DMI scan using one big table?
>
Yes, and such a patch would be appreciated.
The reason it is as it is dates back to before the 32-64 bit
unification, as far as I know.
(BIOS reboot is currently not supported on 64 bits, mainly.)
-hpa
next prev parent reply other threads:[~2012-01-19 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 15:16 [PATCH] x86, reboot: skip DMI checks if reboot set by user Michael D Labriola
2012-01-17 19:58 ` Alan Cox
2012-01-19 15:32 ` Michael D Labriola
2012-01-19 15:45 ` Alan Cox
2012-01-19 15:48 ` Michael D Labriola
[not found] ` <OF8642E997.5ED041E1-ON8525798A.0056983A-8525798A.0056E05B@LocalDomain>
2012-01-19 17:46 ` Michael D Labriola
2012-01-19 17:52 ` H. Peter Anvin [this message]
2012-01-19 19:14 ` Michael D Labriola
2012-01-19 19:17 ` H. Peter Anvin
2012-01-19 19:34 ` Michael D Labriola
2012-01-19 19:41 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F18584F.7060603@zytor.com \
--to=hpa@zytor.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kushalkoolwal@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.d.labriola@gmail.com \
--cc=mingo@elte.hu \
--cc=mjg59@srcf.ucam.org \
--cc=mlabriol@gdeb.com \
--cc=support@versalogic.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.