All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: [PATCH v2] qemu-kvm: Remove icache flush from cpu_physical_memory_rw
Date: Thu, 19 Jan 2012 19:04:38 +0100	[thread overview]
Message-ID: <4F185B36.1070103@siemens.com> (raw)
In-Reply-To: <20120119175409.GA18940@amt.cnet>

On 2012-01-19 18:54, Marcelo Tosatti wrote:
> On Thu, Jan 19, 2012 at 01:39:24PM +0100, Jan Kiszka wrote:
>> This is at best a PPC topi but according to [1] even there unneeded. In
>> any case, remove this diff to upstream, it should be handled there if
>> actually needed.
> 
> [1] ? 
> 

Oops.

--------8<---------

This is at best a PPC topi but according to [1] even there unneeded. In
any case, remove this diff to upstream, it should be handled there if
actually needed.

[1] http://thread.gmane.org/gmane.comp.emulators.qemu/119022/focus=119086

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 exec.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/exec.c b/exec.c
index db837e2..0ca17fc 100644
--- a/exec.c
+++ b/exec.c
@@ -26,8 +26,6 @@
 
 #include "qemu-common.h"
 #include "cpu.h"
-#include "cache-utils.h"
-
 #include "tcg.h"
 #include "hw/hw.h"
 #include "hw/qdev.h"
@@ -3599,11 +3597,6 @@ void cpu_physical_memory_rw(target_phys_addr_t addr, uint8_t *buf,
                     cpu_physical_memory_set_dirty_flags(
                         addr1, (0xff & ~CODE_DIRTY_FLAG));
                 }
-		/* qemu doesn't execute guest code directly, but kvm does
-		   therefore flush instruction caches */
-		if (kvm_enabled())
-		    flush_icache_range((unsigned long)ptr,
-				       ((unsigned long)ptr)+l);
                 qemu_put_ram_ptr(ptr);
             }
         } else {
-- 
1.7.3.4

  reply	other threads:[~2012-01-19 18:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 12:39 [PATCH] qemu-kvm: Remove icache flush from cpu_physical_memory_rw Jan Kiszka
2012-01-19 17:54 ` Marcelo Tosatti
2012-01-19 18:04   ` Jan Kiszka [this message]
2012-01-20 10:25     ` [PATCH v2] " Marcelo Tosatti
2012-01-24  0:26     ` Scott Wood
2012-01-24  8:57       ` Jan Kiszka
2012-01-24 11:34         ` Avi Kivity
2012-01-24 11:38           ` Jan Kiszka
2012-01-24 13:09             ` Avi Kivity
2012-01-24 13:12               ` Jan Kiszka
2012-01-24 13:26                 ` Avi Kivity
2012-01-24 13:29                   ` Jan Kiszka
2012-01-25 14:23                   ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F185B36.1070103@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.