From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 1/2] drm/i915: Remove the MI_FLUSH_ENABLE
 setting.
Date: Thu, 19 Jan 2012 10:59:57 -0800
Message-ID: <4F18682D.9040909@bwidawsk.net>
References: <1326999006-15100-1-git-send-email-eric@anholt.net>
	<86aa5jcylz.fsf@sumi.keithp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id 631389E848
	for <intel-gfx@lists.freedesktop.org>;
	Thu, 19 Jan 2012 11:00:05 -0800 (PST)
In-Reply-To: <86aa5jcylz.fsf@sumi.keithp.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Keith Packard <keithp@keithp.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 01/19/2012 10:54 AM, Keith Packard wrote:
> On Thu, 19 Jan 2012 10:50:05 -0800, Eric Anholt <eric@anholt.net> wrote:
> 
>> -		if (IS_GEN6(dev) || IS_GEN7(dev))
>> -			mode |= MI_FLUSH_ENABLE << 16 | MI_FLUSH_ENABLE;
> 
> This seems better than setting random bits that don't do anything but
> annoy the simulator.

The simulator complains unless both bits are set iirc. I can double
check, but it's been a while since I've run without my patch.

Ben