From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 4/7] tegra: Add I2C driver
Date: Thu, 19 Jan 2012 14:08:46 -0700 [thread overview]
Message-ID: <4F18865E.1070404@nvidia.com> (raw)
In-Reply-To: <1326394818-32227-5-git-send-email-sjg@chromium.org>
On 01/12/2012 12:00 PM, Simon Glass wrote:
> From: Yen Lin <yelin@nvidia.com>
>
> Add basic i2c driver for Tegra2 with 8- and 16-bit address support.
> The driver requires CONFIG_OF_CONTROL to obtain its configuration
> from the device tree.
>
> (Simon Glass: sjg at chromium.org modified for upstream)
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
Why isn't Yen's S-o-b line here, since he's listed as the patch author
in git?
> diff --git a/drivers/i2c/tegra2_i2c.c b/drivers/i2c/tegra2_i2c.c
> +static struct i2c_bus i2c_controllers[CONFIG_SYS_MAX_I2C_BUS];
I still don't like using the wrong define here, but since I see you
pushing the multi-bus stuff upstream, so I assume you'll come back and
fix this when it makes a difference, so I won't object too much about this.
> +void i2c_init(int speed, int slaveaddr)
> +{
> + debug("i2c_init(speed=%u, slaveaddr=0x%x)\n", speed, slaveaddr);
> +}
What was the resolution on making this do something correct instead of
ignoring the request?
--
nvpublic
next prev parent reply other threads:[~2012-01-19 21:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-12 19:00 [U-Boot] [PATCH v2 0/7] tegra: Add I2C driver and associated parts Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 1/7] tegra: Rename NV_PA_PMC_BASE to TEGRA2_PMC_BASE Simon Glass
2012-01-12 19:00 ` [PATCH v2 2/7] fdt: Add function to allow aliases to refer to multiple nodes Simon Glass
2012-01-12 19:00 ` [U-Boot] " Simon Glass
2012-01-19 20:49 ` Stephen Warren
2012-01-19 20:49 ` [U-Boot] " Stephen Warren
2012-01-19 23:45 ` Simon Glass
2012-01-19 23:45 ` [U-Boot] " Simon Glass
2012-01-20 0:17 ` Stephen Warren
2012-01-20 0:17 ` [U-Boot] " Stephen Warren
2012-01-20 0:31 ` Simon Glass
2012-01-20 0:31 ` [U-Boot] " Simon Glass
2012-01-12 19:00 ` [PATCH v2 3/7] tegra: fdt: Add extra I2C bindings for U-Boot Simon Glass
2012-01-12 19:00 ` [U-Boot] " Simon Glass
2012-01-13 6:31 ` Heiko Schocher
2012-01-13 6:31 ` [U-Boot] " Heiko Schocher
[not found] ` <4F0FCFBB.3070407-ynQEQJNshbs@public.gmane.org>
2012-01-13 15:02 ` Simon Glass
2012-01-13 15:02 ` Simon Glass
[not found] ` <1326394818-32227-4-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-19 20:51 ` Stephen Warren
2012-01-19 20:51 ` [U-Boot] " Stephen Warren
2012-01-22 17:41 ` Simon Glass
2012-01-22 17:41 ` [U-Boot] " Simon Glass
[not found] ` <CAPnjgZ0cOquTwqg4wx3Cz1+OKXUzYoBvUi2PMA7oHN=2riOHmQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-01-23 18:25 ` Stephen Warren
2012-01-23 18:25 ` [U-Boot] " Stephen Warren
2012-02-03 23:27 ` Simon Glass
2012-02-03 23:27 ` [U-Boot] " Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 4/7] tegra: Add I2C driver Simon Glass
2012-01-13 7:25 ` Heiko Schocher
2012-01-13 15:09 ` Simon Glass
2012-01-13 15:15 ` Heiko Schocher
2012-01-19 21:08 ` Stephen Warren [this message]
2012-02-03 23:26 ` Simon Glass
2012-02-06 21:41 ` Yen Lin
2012-02-09 17:46 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 5/7] tegra: Initialise I2C on Nvidia boards Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 6/7] tegra: Select I2C ordering for Seaboard Simon Glass
2012-01-19 20:56 ` Stephen Warren
2012-02-03 23:24 ` Simon Glass
2012-02-04 0:14 ` Stephen Warren
2012-02-04 0:19 ` Simon Glass
2012-02-04 0:25 ` Stephen Warren
2012-02-04 0:36 ` Simon Glass
2012-02-04 0:41 ` Stephen Warren
2012-02-04 0:58 ` Simon Glass
2012-01-12 19:00 ` [U-Boot] [PATCH v2 7/7] tegra: Enable I2C on Seaboard Simon Glass
2012-01-13 6:28 ` [U-Boot] [PATCH v2 0/7] tegra: Add I2C driver and associated parts Heiko Schocher
2012-01-13 15:01 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F18865E.1070404@nvidia.com \
--to=swarren@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.