All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 09/20] tegra: Add EMC support for optimal memory timings
Date: Thu, 19 Jan 2012 14:58:53 -0700	[thread overview]
Message-ID: <4F18921D.8020005@nvidia.com> (raw)
In-Reply-To: <1326490535-3461-10-git-send-email-sjg@chromium.org>

On 01/13/2012 02:35 PM, Simon Glass wrote:
> From: Jimmy Zhang <jimmzhang@nvidia.com>
> 
> Add support for setting up the memory controller parameters. Boards
> can set up an appropriate table in the device tree.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
> Changes in v2:
> - Add debug() output to EMC
> - Move EMC tables to device tree

This patch doesn't fully handle the device tree binding. There are two
alternatives:

two-level:

emc {
    ...
    emc-table at 190000 {
        compatible = "nvidia,tegra20-emc-table";
        ...
    };
    emc-table at 380000 {
        compatible = "nvidia,tegra20-emc-table";
        ...
    };
};

three-level:

emc {
    ...
    nvidia,use-ram-code;
    emc-tables {
        nvidia,ram-code = <0>;
        emc-table at 190000 {
            compatible = "nvidia,tegra20-emc-table";
            ...
        };
        emc-table at 380000 {
            compatible = "nvidia,tegra20-emc-table";
            ...
        };
    };
    emc-tables {
        nvidia,ram-code = <1>;
        emc-table at 190000 {
            compatible = "nvidia,tegra20-emc-table";
            ...
        };
        emc-table at 380000 {
            compatible = "nvidia,tegra20-emc-table";
            ...
        };
    };
};

Even if we don't fully implement support for both, we should detect the
unsupported and flag an explicit error. But, it's pretty easy to support
the other format.

BTW, does:

+               node = fdtdec_next_compatible(blob, node,
+                               COMPAT_NVIDIA_TEGRA20_EMC_TABLE);

limit itself to searching child nodes?

-- 
nvpublic

  reply	other threads:[~2012-01-19 21:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-13 21:35 [U-Boot] [PATCH v2 0/20] tegra: warmboot (suspend / resume) support Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 02/20] i2c: Add TPS6586X driver Simon Glass
2012-01-15  7:30   ` Heiko Schocher
2012-03-30 19:21     ` Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 03/20] Add AES crypto library Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 04/20] tegra: Move ap20.h header into arch location Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 05/20] tegra: Add functions to access low-level Osc/PLL details Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 06/20] tegra: Add crypto library for warmboot code Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 07/20] tegra: Add flow, gp_padctl, fuse, sdram headers Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 08/20] tegra: Add tegra_get_chip_type() to detect SKU Simon Glass
2012-01-19 21:43   ` Stephen Warren
2012-01-13 21:35 ` [U-Boot] [PATCH v2 09/20] tegra: Add EMC support for optimal memory timings Simon Glass
2012-01-19 21:58   ` Stephen Warren [this message]
2012-01-19 23:59     ` Simon Glass
2012-01-20  0:10       ` Stephen Warren
2012-04-13 13:31         ` Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 10/20] tegra: Add PMU to manage power supplies Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 11/20] tegra: Set up PMU for Nvidia boards Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 12/20] tegra: Add warmboot implementation Simon Glass
2012-01-19 22:09   ` Stephen Warren
2012-01-13 21:35 ` [U-Boot] [PATCH v2 13/20] tegra: Setup PMC scratch info from ap20 setup Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 14/20] tegra: Set up warmboot code on Nvidia boards Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 15/20] Tegra2: Turn off power detect in board init Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 16/20] tegra: Add EMC settings for Seaboard Simon Glass
     [not found] ` <1326490535-3461-1-git-send-email-sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2012-01-13 21:35   ` [PATCH v2 01/20] fdt: Add function to locate an array in the device tree Simon Glass
2012-01-13 21:35     ` [U-Boot] " Simon Glass
2012-01-13 21:35   ` [PATCH v2 17/20] fdt: tegra: Add EMC node to " Simon Glass
2012-01-13 21:35     ` [U-Boot] " Simon Glass
2012-01-13 21:35   ` [PATCH v2 19/20] tegra: fdt: Add EMC data for Tegra2 Seaboard Simon Glass
2012-01-13 21:35     ` [U-Boot] " Simon Glass
2012-01-13 21:51     ` Simon Glass
2012-01-13 21:51       ` [U-Boot] " Simon Glass
2012-01-13 21:35 ` [U-Boot] [PATCH v2 18/20] tegra: i2c: Add function to find DVC bus Simon Glass
2012-01-15  7:28   ` Heiko Schocher
2012-02-03 23:29     ` Simon Glass
2012-02-06  7:11       ` Heiko Schocher
2012-01-13 21:35 ` [U-Boot] [PATCH v2 20/20] tegra: Enable LP0 on Seaboard Simon Glass
2012-01-15  4:11   ` Mike Frysinger
2012-01-19 22:15   ` Stephen Warren
2012-01-15  4:06 ` [U-Boot] [PATCH v2 0/20] tegra: warmboot (suspend / resume) support Mike Frysinger
2012-03-30 19:24   ` Simon Glass
2012-03-30 21:00     ` Tom Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F18921D.8020005@nvidia.com \
    --to=swarren@nvidia.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.