All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Stanislawski <t.stanislaws@samsung.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>,
	Pawel Osciak <pawel@osciak.com>,
	Sumit Semwal <sumit.semwal@ti.com>,
	linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
	arnd@arndb.de, jesse.barker@linaro.org, m.szyprowski@samsung.com,
	rob@ti.com, daniel@ffwll.ch, patches@linaro.org
Subject: Re: [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf)
Date: Fri, 20 Jan 2012 17:20:22 +0100	[thread overview]
Message-ID: <4F199446.6040403@samsung.com> (raw)
In-Reply-To: <201201201711.50965.laurent.pinchart@ideasonboard.com>

>>
>> IMO, One way to do this is adding field 'struct device *dev' to struct
>> vb2_queue. This field should be filled by a driver prior to calling
>> vb2_queue_init.
>
> I haven't looked into the details, but that sounds good to me. Do we have use
> cases where a queue is allocated before knowing which physical device it will
> be used for ?
>

I don't think so. In case of S5P drivers, vb2_queue_init is called while 
opening /dev/videoX.

BTW. This struct device may help vb2 to produce logs with more 
descriptive client annotation.

What happens if such a device is NULL. It would happen for vmalloc 
allocator used by VIVI?

Regards,
Tomasz Stanislawski

  reply	other threads:[~2012-01-20 16:20 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-05 10:41 [RFCv1 0/4] v4l: DMA buffer sharing support as a user Sumit Semwal
2012-01-05 10:41 ` [RFCv1 1/4] v4l: Add DMABUF as a memory type Sumit Semwal
2012-01-05 10:41 ` [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf) Sumit Semwal
2012-01-14 20:38   ` [Linaro-mm-sig] " Sakari Ailus
     [not found]     ` <CAB2ybb83ub=A45-m6o+RXqFOTUmXCgeFqs03WZDHeWeLe2+29w@mail.gmail.com>
2012-01-16  5:35       ` Semwal, Sumit
2012-01-20 15:04       ` Laurent Pinchart
2012-01-19 19:07   ` Pawel Osciak
2012-01-20 10:41     ` Sumit Semwal
2012-01-20 10:58       ` Tomasz Stanislawski
2012-01-20 15:12         ` Laurent Pinchart
2012-01-20 15:53           ` Tomasz Stanislawski
2012-01-20 16:11             ` Laurent Pinchart
2012-01-20 16:20               ` Tomasz Stanislawski [this message]
2012-01-20 16:28                 ` Laurent Pinchart
2012-01-23  9:06                   ` Marek Szyprowski
2012-01-23  9:40                     ` Daniel Vetter
2012-01-23  9:45                       ` Daniel Vetter
2012-01-23  9:48                     ` Laurent Pinchart
2012-01-23 10:35                       ` Daniel Vetter
2012-01-23 10:54                         ` Laurent Pinchart
2012-01-24  0:26                           ` Clark, Rob
2012-01-24  9:34                             ` Laurent Pinchart
2012-01-24 10:52                               ` Daniel Vetter
2012-01-24 13:03                           ` Daniel Vetter
2012-01-25  8:09                             ` Daniel Vetter
2012-01-30 14:44                             ` Laurent Pinchart
2012-01-30 16:29                               ` Daniel Vetter
2012-01-25 23:28                         ` Sakari Ailus
2012-01-26 11:27                           ` Daniel Vetter
2012-01-29 11:03                             ` Sakari Ailus
2012-01-29 13:03                               ` Daniel Vetter
2012-01-30 14:33                                 ` Laurent Pinchart
2012-01-30 22:01                                 ` Sakari Ailus
2012-01-31 15:38                                   ` Clark, Rob
2012-02-02 10:19                                     ` Laurent Pinchart
2012-02-02 14:01                                       ` Clark, Rob
2012-02-02 14:40                                         ` Sumit Semwal
2012-02-02 20:23                                       ` Daniel Vetter
2012-02-02 20:49                                         ` Clark, Rob
2012-02-04 11:43                                     ` Sakari Ailus
2012-02-05 15:08                                       ` Clark, Rob
2012-01-20 14:55   ` [Linaro-mm-sig] " Laurent Pinchart
2012-01-05 10:41 ` [RFCv1 3/4] v4l:vb: remove warnings about MEMORY_DMABUF Sumit Semwal
2012-01-05 10:41 ` [RFCv1 4/4] v4l:vb2: Add dma-contig allocator as dma_buf user Sumit Semwal
2012-01-16  7:57 ` [RFCv1 0/4] v4l: DMA buffer sharing support as a user Kyungmin Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F199446.6040403@samsung.com \
    --to=t.stanislaws@samsung.com \
    --cc=arnd@arndb.de \
    --cc=daniel@ffwll.ch \
    --cc=jesse.barker@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=patches@linaro.org \
    --cc=pawel@osciak.com \
    --cc=rob@ti.com \
    --cc=sumit.semwal@linaro.org \
    --cc=sumit.semwal@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.