From: Wolfgang Grandegger <wg@grandegger.com>
To: s.grosjean@peak-system.com
Cc: Oliver Hartkopp <oliver.hartkopp@volkswagen.de>,
linux-can Mailing List <linux-can@vger.kernel.org>,
stern@rowland.harvard.edu
Subject: Re: [PATCH 2/3 V3.1] can/usb: PEAK-System Technik PCAN-USB specific part
Date: Fri, 20 Jan 2012 18:32:15 +0100 [thread overview]
Message-ID: <4F19A51F.6040702@grandegger.com> (raw)
In-Reply-To: <4F197FEA.10007@peak-system.com>
Hi Stephane,
On 01/20/2012 03:53 PM, Stephane Grosjean wrote:
> Hi,
>
> Found time to answer to all of you:
>
> - first, thanks for your review and tests
> - next, I did a new version of the driver which fixes Alan's issue about
> the variables in the stack, and which is *very* much less verbose too.
> - the driver itself sets now the can state according to some usb adapter
> events
>
> When unplugging the can cable, candump displays now:
>
> can4 20000004 [8] 00 30 00 00 00 00 00 00 ERRORFRAME
> controller-problem{rx-error-passive,tx-error-passive}
> can4 20000004 [8] 00 30 00 00 00 00 00 00 ERRORFRAME
> controller-problem{rx-error-passive,tx-error-passive}
> can4 20000004 [8] 00 30 00 00 00 00 00 00 ERRORFRAME
> controller-problem{rx-error-passive,tx-error-passive}
> can4 20000004 [8] 00 30 00 00 00 00 00 00 ERRORFRAME
> controller-problem{rx-error-passive,tx-error-passive}
> ...
Does the device report state change to error *warning* as well? Also,
the state change to error passive should only be reported *once*. Well,
it's state change. I don't known what the hardware is actually
reporting. If it does report the current state periodically, you need to
handle it accordingly.
BTW: are the error counters also availabe/readable?
Wolfgang.
next prev parent reply other threads:[~2012-01-20 17:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 10:27 [PATCH 0/3 V3.1] can/usb: Add PEAK-System PCAN USB adapters driver Stephane Grosjean
2012-01-19 10:27 ` [PATCH 2/3 V3.1] can/usb: PEAK-System Technik PCAN-USB specific part Stephane Grosjean
2012-01-19 15:07 ` Alan Stern
2012-01-20 7:52 ` Oliver Hartkopp
2012-01-20 12:28 ` Oliver Hartkopp
2012-01-20 12:34 ` Wolfgang Grandegger
2012-01-20 12:36 ` Wolfgang Grandegger
2012-01-20 13:37 ` Oliver Hartkopp
2012-01-20 13:52 ` Wolfgang Grandegger
2012-01-20 14:53 ` Stephane Grosjean
2012-01-20 17:32 ` Wolfgang Grandegger [this message]
[not found] ` <1326968863-20229-1-git-send-email-s.grosjean-g4cQ8AsIbFbL9ATBNaCtXw@public.gmane.org>
2012-01-19 10:27 ` [PATCH 1/3 V3.1] can/usb: PEAK-System Technik USB adapters driver core Stephane Grosjean
2012-01-19 10:27 ` [PATCH 3/3 V3.1] can/usb: PEAK-System Technik PCAN-USB Pro specific part Stephane Grosjean
2012-01-19 19:08 ` [PATCH 0/3 V3.1] can/usb: Add PEAK-System PCAN USB adapters driver Oliver Hartkopp
2012-01-20 9:28 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F19A51F.6040702@grandegger.com \
--to=wg@grandegger.com \
--cc=linux-can@vger.kernel.org \
--cc=oliver.hartkopp@volkswagen.de \
--cc=s.grosjean@peak-system.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.