From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:41695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RoJxP-00076j-Bt for qemu-devel@nongnu.org; Fri, 20 Jan 2012 14:17:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RoJxJ-0003yK-QT for qemu-devel@nongnu.org; Fri, 20 Jan 2012 14:17:03 -0500 Message-ID: <4F19BD98.3080105@freescale.com> Date: Fri, 20 Jan 2012 13:16:40 -0600 From: Scott Wood MIME-Version: 1.0 References: <1327029449-13220-1-git-send-email-agraf@suse.de> <1327029449-13220-3-git-send-email-agraf@suse.de> In-Reply-To: <1327029449-13220-3-git-send-email-agraf@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/6] PPC: e500mc: add missing IVORs to bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel Developers On 01/19/2012 09:17 PM, Alexander Graf wrote: > E500mc supports IVORs 36-41. Add them to the support mask. > > Signed-off-by: Alexander Graf > --- > target-ppc/translate_init.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 83348b5..7d1c6a3 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -4433,6 +4433,7 @@ enum fsl_e500_version { > static void init_proc_e500 (CPUPPCState *env, int version) > { > uint32_t tlbncfg[2]; > + uint64_t ivor_mask = 0x0000000F0000FFFFULL; > #if !defined(CONFIG_USER_ONLY) > int i; > #endif > @@ -4444,7 +4445,10 @@ static void init_proc_e500 (CPUPPCState *env, int version) > * complain when accessing them. > * gen_spr_BookE(env, 0x0000000F0000FD7FULL); > */ > - gen_spr_BookE(env, 0x0000000F0000FFFFULL); > + if (version == fsl_e500mc) { > + ivor_mask |= 0x3F000000000ULL; > + } > + gen_spr_BookE(env, ivor_mask); > /* Processor identification */ > spr_register(env, SPR_BOOKE_PIR, "PIR", > SPR_NOACCESS, SPR_NOACCESS, What happens when we add e5500 and future chips? We should probably move variant-specific data into a table instead of ad-hocking it. Also, e500mc doesn't just add new IVORs, it drops the SPE IVORs. -Scott