All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brice Goglin <Brice.Goglin@inria.fr>
To: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Cc: julia.lawall@lip6.fr, mmarek@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coccicheck: change handling of C={1,2} when M= is set
Date: Sat, 21 Jan 2012 08:35:29 +0100	[thread overview]
Message-ID: <4F1A6AC1.70300@inria.fr> (raw)
In-Reply-To: <1327101035-7684-2-git-send-email-Gregory.Dietsche@cuw.edu>

Thanks a lot Greg, make C=2 CHECK=script/coccicheck M=... is back.

Tested-by: Brice Goglin <Brice.Goglin@inria.fr>



Le 21/01/2012 00:10, Greg Dietsche a écrit :
> This patch reverts a portion of d0bc1fb4 so that coccicheck will
> work properly when C=1 or C=2.
>
> Reported-by: Brice Goglin <Brice.Goglin@inria.fr>
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
> ---
>  scripts/coccicheck |   13 ++++---------
>  1 files changed, 4 insertions(+), 9 deletions(-)
>
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index 3c27764..823e972 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -9,15 +9,10 @@ if [ "$C" = "1" -o "$C" = "2" ]; then
>  #    FLAGS="-ignore_unknown_options -very_quiet"
>  #    OPTIONS=$*
>  
> -    if [ "$KBUILD_EXTMOD" = "" ] ; then
> -        # Workaround for Coccinelle < 0.2.3
> -        FLAGS="-I $srctree/include -very_quiet"
> -        shift $(( $# - 1 ))
> -        OPTIONS=$1
> -    else
> -	echo M= is not currently supported when C=1 or C=2
> -	exit 1
> -    fi
> +# Workaround for Coccinelle < 0.2.3
> +	FLAGS="-I $srctree/include -very_quiet"
> +	shift $(( $# - 1 ))
> +	OPTIONS=$1
>  else
>      ONLINE=0
>      FLAGS="-very_quiet"


  reply	other threads:[~2012-01-21  7:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4F1928FC.8090300@inria.fr>
2012-01-20 23:10 ` coccicheck in 3.3rc1 Greg Dietsche
2012-01-20 23:10   ` [PATCH] coccicheck: change handling of C={1,2} when M= is set Greg Dietsche
2012-01-21  7:35     ` Brice Goglin [this message]
2012-01-21  7:45       ` Julia Lawall
2012-02-22 15:26       ` Brice Goglin
2012-02-24 22:51         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1A6AC1.70300@inria.fr \
    --to=brice.goglin@inria.fr \
    --cc=Gregory.Dietsche@cuw.edu \
    --cc=julia.lawall@lip6.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.