From: Ryan Mallon <rmallon@gmail.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org, Woogyom Kim <milo.kim@ti.com>,
Daniel Jeong <daniel.jeong@ti.com>,
Minkyu Kang <mk7.kang@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Rhyland Klein <rklein@nvidia.com>,
Peter Edwards <sweetlilmre@gmail.com>,
Anton Vorontsov <cbouatmailru@gmail.com>
Subject: Re: [PATCH] power_supply: Convert power_supply i2c drivers to module_i2c_driver
Date: Sat, 21 Jan 2012 18:55:10 +1100 [thread overview]
Message-ID: <4F1A6F5E.70909@gmail.com> (raw)
In-Reply-To: <1327128174.24831.1.camel@phoenix>
On 21/01/12 17:42, Axel Lin wrote:
> Factor out some boilerplate code for i2c driver registration
> into module_i2c_driver.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Cc: Woogyom Kim <milo.kim@ti.com>
> Cc: Daniel Jeong <daniel.jeong@ti.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Rhyland Klein <rklein@nvidia.com>
> Cc: Peter Edwards <sweetlilmre@gmail.com>
> ---
> drivers/power/ds2782_battery.c | 12 +-----------
> drivers/power/lp8727_charger.c | 13 +------------
> drivers/power/max17040_battery.c | 12 +-----------
> drivers/power/max17042_battery.c | 12 +-----------
> drivers/power/sbs-battery.c | 12 +-----------
> drivers/power/z2_battery.c | 13 +------------
> 6 files changed, 6 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> index bfbce5d..6e3d76a 100644
> --- a/drivers/power/ds2782_battery.c
> +++ b/drivers/power/ds2782_battery.c
> @@ -404,17 +404,7 @@ static struct i2c_driver ds278x_battery_driver = {
> .id_table = ds278x_id,
> };
>
> -static int __init ds278x_init(void)
> -{
> - return i2c_add_driver(&ds278x_battery_driver);
> -}
> -module_init(ds278x_init);
> -
> -static void __exit ds278x_exit(void)
> -{
> - i2c_del_driver(&ds278x_battery_driver);
> -}
> -module_exit(ds278x_exit);
> +module_i2c_driver(ds278x_battery_driver);
>
> MODULE_AUTHOR("Ryan Mallon");
> MODULE_DESCRIPTION("Maxim/Dallas DS2782 Stand-Alone Fuel Gauage IC driver");
For ds2782:
Acked-by: Ryan Mallon <rmallon@gmail.com>
next prev parent reply other threads:[~2012-01-21 7:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-21 6:42 [PATCH] power_supply: Convert power_supply i2c drivers to module_i2c_driver Axel Lin
2012-01-21 7:55 ` Ryan Mallon [this message]
2012-01-21 18:42 ` Kim, Milo
2012-01-23 19:28 ` Rhyland Klein
2012-03-15 17:15 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1A6F5E.70909@gmail.com \
--to=rmallon@gmail.com \
--cc=axel.lin@gmail.com \
--cc=cbouatmailru@gmail.com \
--cc=daniel.jeong@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=milo.kim@ti.com \
--cc=mk7.kang@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=rklein@nvidia.com \
--cc=sweetlilmre@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.