From: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
To: Terry Fryar <terry.fryar@domain.hid>
Cc: xenomai@xenomai.org
Subject: Re: [Xenomai-help] rtdm difficulties
Date: Sat, 21 Jan 2012 17:05:01 +0100 [thread overview]
Message-ID: <4F1AE22D.4070509@domain.hid> (raw)
In-Reply-To: <DE531AD0193E45018B21711AD3A8DB03@domain.hid>
On 01/20/2012 08:37 PM, Terry Fryar wrote:
> Ok, I'll try the patch. A question though...on the beagle, there is a OMAP
> register GPIO_IRQSTATUSx that I am not manually clearing out. This is the
> only place to ack an irq I know of...I assumed that was being handled by the
> kernel? Or is this what the patch is adding?? I'm very new to writing irq
> handlers, as you can tell!
I am not sure what you are talking about, but I guess you do not have
to clear anything on the omap side, the irq demuxing side should take
care about it.
The problem you have look like the edge irq is ticking to fast, and
causing an overflow because we are re-enabling irqs in the middle of
the irq demuxing code. So, if the patch I sent does not solve the
issue, please try the following one. Note that if the irq is indeed
ticking to fast, you are going to replace the stack overflow with a
complete lock-up.
diff --git a/arch/arm/plat-omap/gpio.c b/arch/arm/plat-omap/gpio.c
index 30cb7d4..9c9b6d7 100644
--- a/arch/arm/plat-omap/gpio.c
+++ b/arch/arm/plat-omap/gpio.c
@@ -1229,13 +1229,14 @@ static void gpio_demux_inner(struct gpio_bank *bank, u32 isr, int nonroot)
for (; isr != 0; isr >>= 1, gpio_irq++) {
if (!(isr & 1))
continue;
-
+#if 0
#ifdef CONFIG_IPIPE
if (nonroot) {
local_irq_enable_hw();
local_irq_disable_hw();
}
#endif /* CONFIG_IPIPE */
+#endif
#ifdef CONFIG_ARCH_OMAP1
gpio_index = get_gpio_index(irq_to_gpio(gpio_irq));
@@ -1308,12 +1309,14 @@ static void gpio_irq_handler(unsigned int irq, struct irq_desc *desc)
u32 isr_saved, level_mask = 0;
u32 enabled;
+#if 0
#ifdef CONFIG_IPIPE
if (!bank->nonroot_gpios) {
local_irq_enable_hw();
local_irq_disable_hw();
}
#endif /* CONFIG_IPIPE */
+#endif
enabled = _get_gpio_irqbank_mask(bank);
isr_saved = isr = __raw_readl(isr_reg) & enabled;
--
Gilles.
next prev parent reply other threads:[~2012-01-21 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 16:17 [Xenomai-help] rtdm difficulties Terry Fryar
2012-01-20 17:03 ` Philippe Gerum
2012-01-20 17:42 ` Terry Fryar
2012-01-20 18:19 ` Gilles Chanteperdrix
2012-01-20 18:24 ` Terry Fryar
2012-01-20 18:32 ` Gilles Chanteperdrix
2012-01-20 19:37 ` Terry Fryar
2012-01-20 20:47 ` Philippe Gerum
2012-01-20 21:05 ` [Xenomai-help] rtdm difficulties..fixed Terry Fryar
2012-01-20 21:12 ` [Xenomai-help] rtdm difficulties...not fixed Terry Fryar
2012-01-21 16:05 ` Gilles Chanteperdrix [this message]
2012-01-22 23:32 ` [Xenomai-help] rtdm difficulties Terry Fryar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1AE22D.4070509@domain.hid \
--to=gilles.chanteperdrix@xenomai.org \
--cc=terry.fryar@domain.hid \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.