From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45738) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Romob-0007Dr-OT for qemu-devel@nongnu.org; Sat, 21 Jan 2012 21:05:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Romoa-0007o7-FB for qemu-devel@nongnu.org; Sat, 21 Jan 2012 21:05:53 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36993 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Romoa-0007o1-5n for qemu-devel@nongnu.org; Sat, 21 Jan 2012 21:05:52 -0500 Message-ID: <4F1B6E88.7090606@suse.de> Date: Sun, 22 Jan 2012 03:03:52 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1326674823-13069-1-git-send-email-afaerber@suse.de> <1326674823-13069-3-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/14] target-sparc: Fix mixup of uint64 and uint64_t List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: qemu-devel@nongnu.org, Richard Henderson Am 21.01.2012 19:51, schrieb Blue Swirl: > On Mon, Jan 16, 2012 at 00:46, Andreas F=C3=A4rber w= rote: >> Commit 793a137a41ad4125011c7022cf16a1baa40a5ab6 (target-sparc: >> Implement BMASK/BSHUFFLE.) introduced a stray usage of softfloat uint6= 4 >> type. >> >> Use uint64_t instead. >> >> Signed-off-by: Andreas F=C3=A4rber >> Cc: Richard Henderson >> Cc: Blue Swirl >=20 > Good catch, > Reviewed-by: Blue Swirl Feel free to apply this patch if Richard doesn't comment. The rest of the series needs some more review and benchmarking. Is there maybe a way to poison these types outside fpu/ meanwhile? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg