From: Thomas Goirand <thomas@goirand.fr>
To: mlmmj@mlmmj.org
Subject: Re: [mlmmj] [patch] Remove bashism from src/mlmmj-make-ml.sh.in
Date: Sun, 22 Jan 2012 18:56:34 +0000 [thread overview]
Message-ID: <4F1C5BE2.7070503@goirand.fr> (raw)
In-Reply-To: <4F1BC034.5060304@goirand.fr>
On 01/22/2012 09:27 PM, Ben Schmidt wrote:
> On 22/01/12 11:23 PM, Mark Alan wrote:
>> On Sun, 22 Jan 2012 15:52:20 +0800, Thomas Goirand<thomas@goirand.fr>
>> wrote:
>>
>>> - echo -e "$0: invalid option\nTry $0 -h for more information."
>>> + echo "$0: invalid option"
>>> + echo "Try $0 -h for more information."
>>
>> Better yet, use a single command:
>> - echo -e "$0: invalid option\nTry $0 -h for more information."
>> + printf "$0: invalid option\nTry $0 -h for more information.\n"
>
> Are you sure this is sh compatible?
The Debian "checkbashisms" script doesn't report any error with it.
> I wonder if the echo version is perhaps more readable, and thus
> preferable anyway, rather than single-command wizardry. What do you
> think?
I agree.
Thomas
next prev parent reply other threads:[~2012-01-22 18:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 7:52 [mlmmj] [patch] Remove bashism from src/mlmmj-make-ml.sh.in Thomas Goirand
2012-01-22 12:23 ` Mark Alan
2012-01-22 13:27 ` Ben Schmidt
2012-01-22 13:36 ` Yuri D'Elia
2012-01-22 18:56 ` Thomas Goirand [this message]
2012-01-23 0:18 ` Ben Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1C5BE2.7070503@goirand.fr \
--to=thomas@goirand.fr \
--cc=mlmmj@mlmmj.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.