All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Jörg Otte" <jrg.otte@googlemail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [v3.3-rc1] media:dvb-t regression bisected
Date: Mon, 23 Jan 2012 09:14:20 -0200	[thread overview]
Message-ID: <4F1D410C.5010105@redhat.com> (raw)
In-Reply-To: <CADDKRnDHvptV_gODG8XgqEkWGW0AyDfJJkP1dU2uBL6rs5yzDA@mail.gmail.com>

Em 22-01-2012 13:29, Jörg Otte escreveu:
> with v3.3-rc1 I can not watch dvb-t. I get the following
> errors from the media player (Kaffeine,vlc):
> 
> kaffeine(1801): DvbDevice::frontendEvent: tuning failed
> vlc: [0xa278d78] main stream error: cannot pre fill buffer
> 
> I have a CinergyT2 usb-stick.
> 
> I was able to bisect the problem to:
> commit 7830bbaff9f5f9cefcdc9acfb1783b230cc69fac
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date:   Mon Dec 26 15:41:01 2011 -0300
> 
> [media] cinergyT2-fe: convert set_fontend to use DVBv5 parameters

Could you please try this patch?

[PATCH] cinergyT2-fe: Fix bandwdith settings

Changeset 7830bbaff9f mangled the bandwidth field for CinergyT2.
Properly fill it.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

diff --git a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
index 8a57ed8..1efc028 100644
--- a/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
+++ b/drivers/media/dvb/dvb-usb/cinergyT2-fe.c
@@ -276,14 +276,15 @@ static int cinergyt2_fe_set_frontend(struct dvb_frontend *fe)
 	param.flags = 0;
 
 	switch (fep->bandwidth_hz) {
+	default:
 	case 8000000:
-		param.bandwidth = 0;
+		param.bandwidth = 8;
 		break;
 	case 7000000:
-		param.bandwidth = 1;
+		param.bandwidth = 7;
 		break;
 	case 6000000:
-		param.bandwidth = 2;
+		param.bandwidth = 6;
 		break;
 	}
 

  reply	other threads:[~2012-01-23 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-22 15:29 [v3.3-rc1] media:dvb-t regression bisected Jörg Otte
2012-01-23 11:14 ` Mauro Carvalho Chehab [this message]
2012-01-23 11:45 ` Mauro Carvalho Chehab
2012-01-23 15:09   ` Jörg Otte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1D410C.5010105@redhat.com \
    --to=mchehab@redhat.com \
    --cc=jrg.otte@googlemail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.