From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:36051)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RpHxD-00058V-51
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 06:20:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RpHx8-0008TK-VQ
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 06:20:51 -0500
Received: from goliath.siemens.de ([192.35.17.28]:16365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1RpHx8-0008Sw-Ms
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 06:20:46 -0500
Message-ID: <4F1D428A.1050005@siemens.com>
Date: Mon, 23 Jan 2012 12:20:42 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1327310329-15294-1-git-send-email-hpoussin@reactos.org>
In-Reply-To: <1327310329-15294-1-git-send-email-hpoussin@reactos.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] rtc: initialize irq even if caller doesn't
 use rtc_init() function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= <hpoussin@reactos.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On 2012-01-23 10:18, Herv=C3=A9 Poussineau wrote:
> rtc instanciated with -device has now a working irq line

That makes no sense. The mc146818rtc is no_user - for a reason.

What is the use case you are trying to address?

Jan

>=20
> Signed-off-by: Herv=C3=A9 Poussineau <hpoussin@reactos.org>
> ---
>  hw/mc146818rtc.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index 657fa10..3067022 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -672,6 +672,7 @@ static int rtc_initfn(ISADevice *dev)
> =20
>      memory_region_init_io(&s->io, &cmos_ops, s, "rtc", 2);
>      isa_register_ioport(dev, &s->io, base);
> +    isa_init_irq(dev, &s->irq, RTC_ISA_IRQ);
> =20
>      qdev_set_legacy_instance_id(&dev->qdev, base, 2);
>      qemu_register_reset(rtc_reset, s);
> @@ -692,9 +693,8 @@ ISADevice *rtc_init(ISABus *bus, int base_year, qem=
u_irq intercept_irq)
>      qdev_prop_set_int32(&dev->qdev, "base_year", base_year);
>      qdev_init_nofail(&dev->qdev);
>      if (intercept_irq) {
> +        /* Use provided IRQ instead of default one */
>          s->irq =3D intercept_irq;
> -    } else {
> -        isa_init_irq(dev, &s->irq, RTC_ISA_IRQ);
>      }
>      return dev;
>  }

--=20
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux