All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Hervé Poussineau" <hpoussin@reactos.org>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] rtc: initialize irq even if caller doesn't use rtc_init() function
Date: Mon, 23 Jan 2012 13:00:43 +0100	[thread overview]
Message-ID: <4F1D4BEB.3040904@reactos.org> (raw)
In-Reply-To: <4F1D428A.1050005@siemens.com>

Jan Kiszka a écrit :
> On 2012-01-23 10:18, Hervé Poussineau wrote:
>> rtc instanciated with -device has now a working irq line
> 
> That makes no sense. The mc146818rtc is no_user - for a reason.
> 
> What is the use case you are trying to address?
> 

I wanted to be able to instanciate it with isa_create_simple(isa_bus, 
"mc146818rtc") in machine init code.
I don't see any good reason why a rtc created this way can't work.

The commit message can be changed to:
"rtc: initialize irq even if caller doesn't use rtc_init() function
rtc instancianted with isa_create_simple() has now a working irq line"
if you prefer...

Hervé

  reply	other threads:[~2012-01-23 12:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-23  9:18 [Qemu-devel] [PATCH] rtc: initialize irq even if caller doesn't use rtc_init() function Hervé Poussineau
2012-01-23 11:20 ` Jan Kiszka
2012-01-23 12:00   ` Hervé Poussineau [this message]
2012-01-23 12:06     ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1D4BEB.3040904@reactos.org \
    --to=hpoussin@reactos.org \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.