All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@siemens.com>
To: Christoph Egger <Christoph.Egger@amd.com>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] signrom.sh: portability fix
Date: Mon, 23 Jan 2012 15:31:21 +0100	[thread overview]
Message-ID: <4F1D6F39.7070007@siemens.com> (raw)
In-Reply-To: <0014CB49-6AA0-43C3-9323-C0B38D3E6452@suse.de>

On 2009-07-17 16:37, Alexander Graf wrote:
> 
> On 17.07.2009, at 15:23, Christoph Egger wrote:
> 
>>
>> Hi!
>>
>> Attached patch makes signrom.sh working on NetBSD.
>> The output of the 'od' command leads to a syntax error
>> which breaks the build.
> 
> So why replace the $(( ... )) calculation with expr then? A few lines
> below there's another $(( )) that apparently works.

Picking up this old topic again: Forking expr in this tight loop is a
very bad idea. It makes signing a fairly long running step of the build
process for any non-trivial rom (I'm about to add one of those).

Can you please provide an example output for the ${nums} variable that
used to break for you so that we can find a fork-free algorithm?

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux

  reply	other threads:[~2012-01-23 14:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-17 13:23 [Qemu-devel] [PATCH] signrom.sh: portability fix Christoph Egger
2009-07-17 14:37 ` Alexander Graf
2012-01-23 14:31   ` Jan Kiszka [this message]
  -- strict thread matches above, loose matches on Subject: below --
2009-07-17 16:06 Christoph Egger
2009-07-20  7:48 ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1D6F39.7070007@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=Christoph.Egger@amd.com \
    --cc=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.