Re: [Qemu-devel] [PATCH] usb-redir: Add the posibility to filter out certain devices from redirecion

[Gerd Hoffmann <kraxel@redhat.com>]

On 01/13/12 08:43, Gerd Hoffmann wrote:
> On 01/12/12 17:31, Hans de Goede wrote:
>> This patch adds the posibility to filter out certain devices from redirecion.
>> To use this pass the filter property to -device usb-redir.  The filter
>> property takes a string consisting of filter rules, the format for a rule is:
>> <class>:<vendor>:<product>:<version>:<allow>
> 
> Hmm, what is the point of having this filter in qemu?
> 
> I'd expect the other end of the network connection which talks to the
> actual usb device (i.e. the tcp standalone server or spice client) doing
> the filtering ...

Also fails checkpatch:

WARNING: line over 80 characters
#75: FILE: usb-redir.c:898:
+            qerror_report(QERR_INVALID_PARAMETER_VALUE, "filter", "a
usb device filter string");

total: 0 errors, 1 warnings, 208 lines checked

cheers,
  Gerd