From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH 11/21] mini-os: make frontends and xenbus optional Date: Mon, 23 Jan 2012 11:21:48 -0500 Message-ID: <4F1D891C.4050508@tycho.nsa.gov> References: <1327092461-2701-1-git-send-email-dgdegra@tycho.nsa.gov> <1327092461-2701-12-git-send-email-dgdegra@tycho.nsa.gov> <1327325368.24561.130.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1327325368.24561.130.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 01/23/2012 08:29 AM, Ian Campbell wrote: > On Fri, 2012-01-20 at 20:47 +0000, Daniel De Graaf wrote: >> This adds compile-time logic to disable certain frontends in mini-os: >> - pcifront is disabled by default, enabled for ioemu >> - blkfront, netfront, fbfront, and kbdfront are enabled by default >> - xenbus is required for any frontend, and is enabled by default >> >> If all frontends and xenbus are disabled, mini-os will run without >> needing to communicate with xenstore, making it suitable to run the >> xenstore daemon. > > I should've read this properly first time, then it wouldn't have taken > me until 17/21 to figure it out. > > I think would be worthwhile to refactor the xenstore driver "extra" > consoles from the single console provided via start info and to make the > former a configurable option in line with the other front end drivers. > That would, I think, tidy up the changes to xencons_ring. I think > free_consfront and init_consfront only apply to the extra console case > so the ifdefs you add within them would instead surround the whole > functions (or even consfront.o if you decide that works). > > Ian. > Ah, I hadn't noticed that minios supported multiple consoles; that explains a lot of the xenstore dependencies here. In that case, I think it'd be useful to add CONFIG_CONSFRONT to allow dropping that support (possibly refactoring into multiple files). -- Daniel De Graaf National Security Agency