From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37070) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpNPm-0001Ez-IC for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:10:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpNPe-0007Q3-At for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:10:42 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:45267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpNPe-0007Pn-5Y for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:10:34 -0500 Received: from /spool/local by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 23 Jan 2012 10:10:31 -0700 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 25D8E3E40BBC for ; Mon, 23 Jan 2012 10:06:07 -0700 (MST) Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q0NH66pN263246 for ; Mon, 23 Jan 2012 12:06:06 -0500 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q0NH5tfO006155 for ; Mon, 23 Jan 2012 10:05:56 -0700 Message-ID: <4F1D9355.9010904@us.ibm.com> Date: Mon, 23 Jan 2012 11:05:25 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <87vco2tvux.fsf@linux.vnet.ibm.com> In-Reply-To: <87vco2tvux.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PULL] VirtFS update List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: QEMU Developers On 01/23/2012 07:02 AM, Aneesh Kumar K.V wrote: > > > The following changes since commit 8c4ec5c0269bda18bb777a64b2008088d1c632dc: > > pxa2xx_keypad: fix unbalanced parenthesis. (2012-01-17 02:14:42 +0100) > > are available in the git repository at: > > git://github.com/kvaneesh/QEMU.git for-upstream > > for you to fetch changes up to 0700a73cfe166100cb59e28aad2c1fc5e4e952cb: > > hw/9pfs: Update MAINTAINERS file (2012-01-23 12:26:54 +0530) CC libhw64/9pfs/virtio-9p-local.o cc1: warnings being treated as errors /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c: In function ‘local_set_mapped_file_attr’: /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:9: error: ‘uid’ may be used uninitialized in this function /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:14: error: ‘gid’ may be used uninitialized in this function /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:19: error: ‘mode’ may be used uninitialized in this function /home/anthony/git/qemu/hw/9pfs/virtio-9p-local.c:153:25: error: ‘rdev’ may be used uninitialized in this function make[1]: *** [9pfs/virtio-9p-local.o] Error 1 make: *** [subdir-libhw64] Error 2 I see a lot of build breakages come into through this tree. I understand that GCC can be fickle with -Werror but there's an easy way to solve this. Please get your tree added to buildbot and make sure there's a successful buildbot run before you do a pull request. Alternatively, setup multiple VMs to build test yourself. But please do something to check the build a bit more rigorously before sending future PULL requests. Regards, Anthony Liguori > > ---------------------------------------------------------------- > (from the branch description for for-upstream local branch) > > branch for landing changes for upstream merge > > ---------------------------------------------------------------- > Aneesh Kumar K.V (3): > hw/9pfs: Add new security model mapped-file. > hw/9pfs: Fix crash when mounting with synthfs > hw/9pfs: Update MAINTAINERS file > > M. Mohan Kumar (2): > hw/9pfs: Preserve S_ISGID > fsdev: Fix parameter parsing for proxy helper > > MAINTAINERS | 6 +- > fsdev/file-op-9p.h | 12 +- > fsdev/virtfs-proxy-helper.c | 10 +- > hw/9pfs/cofile.c | 14 ++ > hw/9pfs/virtio-9p-device.c | 9 - > hw/9pfs/virtio-9p-handle.c | 4 +- > hw/9pfs/virtio-9p-local.c | 348 ++++++++++++++++++++++++++++++++++++++++++- > hw/9pfs/virtio-9p.c | 2 +- > qemu-options.hx | 18 ++- > 9 files changed, 388 insertions(+), 35 deletions(-) > > >