From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:38245)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RpNip-0004F9-3k
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:30:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1RpNij-0001u3-HQ
	for qemu-devel@nongnu.org; Mon, 23 Jan 2012 12:30:23 -0500
Message-ID: <4F1D9912.1090803@freescale.com>
Date: Mon, 23 Jan 2012 11:29:54 -0600
From: Scott Wood <scottwood@freescale.com>
MIME-Version: 1.0
References: <1327119330-29304-1-git-send-email-agraf@suse.de>
	<1327119330-29304-7-git-send-email-agraf@suse.de>
In-Reply-To: <1327119330-29304-7-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 6/8] PPC: booke: add tlbnps handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc@nongnu.org, qemu-devel Developers <qemu-devel@nongnu.org>

On 01/20/2012 10:15 PM, Alexander Graf wrote:
> +/* returns bitmap of supported page sizes for a given TLB */
> +static inline uint32_t booke206_tlbnps(CPUState *env, const int tlbn)
> +{
> +    bool mav2 = false;
> +    uint32_t ret = 0;
> +
> +    if (mav2) {
> +        ret = env->spr[SPR_BOOKE_TLB0PS + tlbn];
> +    } else {
> +        uint32_t tlbncfg = env->spr[SPR_BOOKE_TLB0CFG + tlbn];
> +        uint32_t min = (tlbncfg & TLBnCFG_MINSIZE) >> TLBnCFG_MINSIZE_SHIFT;
> +        uint32_t max = (tlbncfg & TLBnCFG_MAXSIZE) >> TLBnCFG_MAXSIZE_SHIFT;
> +        int i;
> +        for (i = min; i <= max; i++) {
> +            ret |= (1 << (i << 1));
> +        }
> +    }

For mav1 only the even sizes are supported.

-Scott