All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jürgen Kilb" <j.kilb@phytec.de>
To: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] ARM pca-a-l1: fix board_init
Date: Mon, 23 Jan 2012 22:17:53 +0100	[thread overview]
Message-ID: <4F1DCE81.4070208@phytec.de> (raw)
In-Reply-To: <20120123104054.GR25622@game.jcrosoft.org>

Hi Jean-Christophe

On 23.01.2012 11:40, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 22:25 Fri 20 Jan     , Juergen Kilb wrote:
>> board_init was moved to pure_initcall. broken since:
>>
>> commit 0adce7ec683b4b325f51de4ac8892b32925d7ef8
>> Author: Sascha Hauer<s.hauer@pengutronix.de>
>> Date:   Sun Jan 15 21:11:17 2012 +0100
>>
>>      ARM omap3: move board_init to pure_initcall
>>
>>      board_init initializes the mux and sdram. For both there is no
>>      need to configure this so early. Move the code to a pure_initcall
>>      and remove the surrounding unneeded code.
>>
>>      Signed-off-by: Sascha Hauer<s.hauer@pengutronix.de>
>>      Tested-by: Sanjeev Premi<premi@ti.com>
>>
>> Signed-off-by: Juergen Kilb<J.Kilb@phytec.de>
> can't you fix all in one patch?
I'v used separate patches because the break was created by two different 
commits and the other two doesn't depend on each other.
>> ---
>>   arch/arm/boards/phycard-a-l1/pca-a-l1.c |    8 +++++---
>>   arch/arm/mach-omap/Kconfig              |    1 -
>>   barebox_default_env.gz                  |  Bin 0 ->  2656 bytes
>>   3 files changed, 5 insertions(+), 4 deletions(-)
>>   create mode 100644 barebox_default_env.gz
> ???
ups.. have not seen this. Was a result of 'git add .'
> Best Regards,
> J.
greetings,
Jürgen


_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  reply	other threads:[~2012-01-23 21:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 21:25 [PATCH] ARM pca-a-l1: call omap3_core_init from board code Juergen Kilb
2012-01-20 21:25 ` [PATCH] ARM pca-a-l1: delete platform.S Juergen Kilb
2012-01-20 21:25 ` [PATCH] ARM pca-a-l1: fix board_init Juergen Kilb
2012-01-23  8:35   ` Sascha Hauer
2012-01-23 10:40   ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-23 21:17     ` Jürgen Kilb [this message]
2012-01-20 21:25 ` [PATCH] ARM pca-a-l1: should depend on ARCH_OMAP3 Juergen Kilb
  -- strict thread matches above, loose matches on Subject: below --
2012-01-17 10:23 [PATCH] ARM pca-a-l1: fix board_init Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F1DCE81.4070208@phytec.de \
    --to=j.kilb@phytec.de \
    --cc=barebox@lists.infradead.org \
    --cc=plagnioj@jcrosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.