From: jdzheng@broadcom.com (Jiandong Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: fix build failure in mach-bcmring/arch.c
Date: Mon, 23 Jan 2012 16:52:11 -0800 [thread overview]
Message-ID: <4F1E00BB.9070705@broadcom.com> (raw)
In-Reply-To: <1327263990-8769-1-git-send-email-paul.gortmaker@windriver.com>
On 1/22/2012 12:26 PM, Paul Gortmaker wrote:
> Upstream commit d1fce9c115eeb93e01c01732dfe9a86cf76009cf
>
> "ARM: restart: bcmring: use new restart hook"
>
> breaks building of this platform, since what used to be the
> last field of the MACHINE_START/END block didn't have a
> trailing comma. Once another field was added below, we get:
>
> arch/arm/mach-bcmring/arch.c:198: error: request for member 'restart' in something not a structure or union
>
> Signed-off-by: Paul Gortmaker<paul.gortmaker@windriver.com>
>
> diff --git a/arch/arm/mach-bcmring/arch.c b/arch/arm/mach-bcmring/arch.c
> index 9e5e755..45c97b1 100644
> --- a/arch/arm/mach-bcmring/arch.c
> +++ b/arch/arm/mach-bcmring/arch.c
> @@ -194,6 +194,6 @@ MACHINE_START(BCMRING, "BCMRING")
> .init_early = bcmring_init_early,
> .init_irq = bcmring_init_irq,
> .timer =&bcmring_timer,
> - .init_machine = bcmring_init_machine
> + .init_machine = bcmring_init_machine,
> .restart = bcmring_restart,
> MACHINE_END
Acked-by: Jiandong Zheng <jdzheng@broadcom.com>
next prev parent reply other threads:[~2012-01-24 0:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-22 20:26 [PATCH] arm: fix build failure in mach-bcmring/arch.c Paul Gortmaker
2012-01-24 0:52 ` Jiandong Zheng [this message]
2012-02-04 19:30 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F1E00BB.9070705@broadcom.com \
--to=jdzheng@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.