Re: [PATCH 2 of 3] libxl: name libxl_create_cpupool consistent with other functions

[Juergen Gross <juergen.gross@ts.fujitsu.com>]

On 01/23/2012 03:43 PM, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell<ian.campbell@citrix.com>
> # Date 1327329347 0
> # Node ID 10f5656caaaa2bdfd6a7ae9aada903da8bddcbb6
> # Parent  c91bee33280debdfe602d28e48318c03ddf0f4c9
> libxl: name libxl_create_cpupool consistent with other functions.
>
> The pattern for the other cpupool functions is libxl_cpupool_<ACTION>
> and in general we use libxl_<THING>_<ACTION>
>
> Signed-off-by: Ian Campbell<ian.campbell@citrix.com>
Acked-by: juergen.gross@ts.fujitsu.com
> diff -r c91bee33280d -r 10f5656caaaa tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c	Mon Jan 23 14:35:46 2012 +0000
> +++ b/tools/libxl/libxl.c	Mon Jan 23 14:35:47 2012 +0000
> @@ -3172,7 +3172,7 @@ int libxl_get_freecpus(libxl_ctx *ctx, l
>       return 0;
>   }
>
> -int libxl_create_cpupool(libxl_ctx *ctx, const char *name, int schedid,
> +int libxl_cpupool_create(libxl_ctx *ctx, const char *name, int schedid,
>                            libxl_cpumap cpumap, libxl_uuid *uuid,
>                            uint32_t *poolid)
>   {
> diff -r c91bee33280d -r 10f5656caaaa tools/libxl/libxl.h
> --- a/tools/libxl/libxl.h	Mon Jan 23 14:35:46 2012 +0000
> +++ b/tools/libxl/libxl.h	Mon Jan 23 14:35:47 2012 +0000
> @@ -605,7 +605,7 @@ int libxl_tmem_shared_auth(libxl_ctx *ct
>   int libxl_tmem_freeable(libxl_ctx *ctx);
>
>   int libxl_get_freecpus(libxl_ctx *ctx, libxl_cpumap *cpumap);
> -int libxl_create_cpupool(libxl_ctx *ctx, const char *name, int schedid,
> +int libxl_cpupool_create(libxl_ctx *ctx, const char *name, int schedid,
>                            libxl_cpumap cpumap, libxl_uuid *uuid,
>                            uint32_t *poolid);
>   int libxl_cpupool_destroy(libxl_ctx *ctx, uint32_t poolid);
> diff -r c91bee33280d -r 10f5656caaaa tools/libxl/xl_cmdimpl.c
> --- a/tools/libxl/xl_cmdimpl.c	Mon Jan 23 14:35:46 2012 +0000
> +++ b/tools/libxl/xl_cmdimpl.c	Mon Jan 23 14:35:47 2012 +0000
> @@ -5332,7 +5332,7 @@ int main_cpupoolcreate(int argc, char **
>           return 0;
>
>       poolid = 0;
> -    if (libxl_create_cpupool(ctx, name, schedid, cpumap,&uuid,&poolid)) {
> +    if (libxl_cpupool_create(ctx, name, schedid, cpumap,&uuid,&poolid)) {
>           fprintf(stderr, "error on creating cpupool\n");
>           return -ERROR_FAIL;
>       }
> @@ -5706,7 +5706,7 @@ int main_cpupoolnumasplit(int argc, char
>           snprintf(name, 15, "Pool-node%d", node);
>           libxl_uuid_generate(&uuid);
>           poolid = 0;
> -        ret = -libxl_create_cpupool(ctx, name, schedid, cpumap,&uuid,&poolid);
> +        ret = -libxl_cpupool_create(ctx, name, schedid, cpumap,&uuid,&poolid);
>           if (ret) {
>               fprintf(stderr, "error on creating cpupool\n");
>               goto out;
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>


-- 
Juergen Gross                 Principal Developer Operating Systems
PDG ES&S SWE OS6                       Telephone: +49 (0) 89 3222 2967
Fujitsu Technology Solutions              e-mail: juergen.gross@ts.fujitsu.com
Domagkstr. 28                           Internet: ts.fujitsu.com
D-80807 Muenchen                 Company details: ts.fujitsu.com/imprint.html