From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:55288) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpakX-0007s1-Sq for qemu-devel@nongnu.org; Tue, 24 Jan 2012 02:25:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpakW-0006XV-K0 for qemu-devel@nongnu.org; Tue, 24 Jan 2012 02:25:01 -0500 Received: from cantor2.suse.de ([195.135.220.15]:58072 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpakW-0006XG-9A for qemu-devel@nongnu.org; Tue, 24 Jan 2012 02:25:00 -0500 Message-ID: <4F1E5C49.4030604@suse.de> Date: Tue, 24 Jan 2012 08:22:49 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <75020d27a76d9b884a9c40d8c6ec81b525ab96a9.1327302677.git.peter.crosthwaite@petalogix.com> In-Reply-To: <75020d27a76d9b884a9c40d8c6ec81b525ab96a9.1327302677.git.peter.crosthwaite@petalogix.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 5/7] vl.c: added -kerndtb option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Peter A. G. Crosthwaite" Cc: Peter Maydell , monstr@monstr.eu, edgar.iglesias@petalogix.com, qemu-devel@nongnu.org, duyl@xilinx.com, linnj@xilinx.com, john.williams@petalogix.com Am 23.01.2012 08:20, schrieb Peter A. G. Crosthwaite: > Added linux specific kernel dtb option. This option can be specified to= inject > an argument device tree blob (dtb) into linux. >=20 > Signed-off-by: Peter A. G. Crosthwaite > --- > qemu-options.hx | 3 +++ > vl.c | 4 ++++ > 2 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/qemu-options.hx b/qemu-options.hx > index 6295cde..43cddff 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -1931,6 +1931,9 @@ ETEXI > =20 > DEF("kernel", HAS_ARG, QEMU_OPTION_kernel, \ > "-kernel bzImage use 'bzImage' as kernel image\n", QEMU_ARCH_ALL) > +DEF("kern-dtb", HAS_ARG, QEMU_OPTION_kerndtb, \ > + "-kern-dtb dtb device tree blob passed to kernel boot\n", QEMU_ARC= H_ALL) We should probably call it -kernel-dtb. If there's some strncmp() from -kernel interfering, we should fix that instead. I don't see this variable being used anywhere in this series though. Would it have been in the missing zynq machine of 7/7? Andreas > + > STEXI > @item -kernel @var{bzImage} > @findex -kernel > diff --git a/vl.c b/vl.c > index d5868b1..75246f8 100644 > --- a/vl.c > +++ b/vl.c > @@ -233,6 +233,7 @@ int boot_menu; > uint8_t *boot_splash_filedata; > int boot_splash_filedata_size; > uint8_t qemu_extra_params_fw[2]; > +const char *qemu_kerndtb =3D NULL; > =20 > typedef struct FWBootEntry FWBootEntry; > =20 > @@ -2437,6 +2438,9 @@ int main(int argc, char **argv, char **envp) > case QEMU_OPTION_kernel: > kernel_filename =3D optarg; > break; > + case QEMU_OPTION_kerndtb: > + qemu_kerndtb =3D optarg; > + break; > case QEMU_OPTION_append: > kernel_cmdline =3D optarg; > break; --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg