From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpbRs-0007zQ-O9 for qemu-devel@nongnu.org; Tue, 24 Jan 2012 03:09:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RpbRm-0004ci-Sw for qemu-devel@nongnu.org; Tue, 24 Jan 2012 03:09:48 -0500 Received: from cantor2.suse.de ([195.135.220.15]:59642 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RpbRm-0004cU-Kq for qemu-devel@nongnu.org; Tue, 24 Jan 2012 03:09:42 -0500 Message-ID: <4F1E66C5.2040703@suse.de> Date: Tue, 24 Jan 2012 09:07:33 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 1/7] cadence_uart: first revision List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Peter A. G. Crosthwaite" Cc: Peter Maydell , monstr@monstr.eu, edgar.iglesias@petalogix.com, qemu-devel@nongnu.org, Anthony Liguori , duyl@xilinx.com, linnj@xilinx.com, john.williams@petalogix.com Am 23.01.2012 08:20, schrieb Peter A. G. Crosthwaite: > Device model for Cadence UART >=20 > Signed-off-by: Peter A. G. Crosthwaite > --- > Makefile.target | 1 + > hw/cadence_uart.c | 619 +++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 620 insertions(+), 0 deletions(-) > create mode 100644 hw/cadence_uart.c > diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c > new file mode 100644 > index 0000000..931ff2c > --- /dev/null > +++ b/hw/cadence_uart.c > +typedef struct { [...] > +} uart_state; Coding Style mandates CamelCase for structs. > +static void uart_register_devices(void) > +{ > + sysbus_register_dev("cadence_uart", sizeof(uart_state), > + uart_init); Please use sysbus_register_withprop() instead, for the upcoming QOM conversion. Could you also consider adding VMState for the devices, to allow load/save? If not, they should at least be marked as unmigratable. > +} Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg